Layout/MultilineAssignmentLayout causes weird indentation

[ioquatix]

Here is the source code test case:

# Is it broken?
def my_method
  return [] if my_thing
  foo = if condition
          foo = bar rescue "{}"
          update(foo)
          JSON.parse(foo) rescue []
        else
          JSON.parse(stuff) rescue []
        end
  questions
end

Here is the configuration:

Layout/MultilineAssignmentLayout:
  Enabled: true

Layout/EndAlignment:
  Enabled: true
  EnforcedStyleAlignWith: variable
  AutoCorrect: true

If you disable Layout/MultilineAssignmentLayout it works better.

Expected behavior

# Is it broken?
def my_method
  return [] if my_thing

  foo =
    if condition
      foo =
        begin
          bar
        rescue StandardError
          '{}'
        end
      update(foo)
      begin
        JSON.parse(foo)
      rescue StandardError
        []
      end
    else
      begin
        JSON.parse(stuff)
      rescue StandardError
        []
      end
    end
  questions
end

Actual behavior

# Is it broken?
def my_method
  return [] if my_thing

  foo =
    if condition
      foo =
        begin
                           bar
        rescue StandardError
          '{}'
                         end
      update(foo)
      begin
        JSON.parse(foo)
      rescue StandardError
        []
      end
    else
      begin
        JSON.parse(stuff)
      rescue StandardError
        []
      end
    end
  questions
end

Steps to reproduce the problem

rubocop -a

RuboCop version

koyoko% rubocop -V
0.89.1 (using Parser 2.7.1.4, rubocop-ast 0.3.0, running on ruby 2.7.1 x86_64-linux)

[ioquatix]

Actually, I'm wrong, it's not Layout/MultilineAssignmentLayout causing the issue, but maybe Style/RescueModifier.

[ioquatix]

Thanks!

[koic]

@ioquatix You are welcome!