Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I'm temporarily disabling the issue tracker #1760

Closed
asottile opened this issue Nov 24, 2022 · 1 comment
Closed

I'm temporarily disabling the issue tracker #1760

asottile opened this issue Nov 24, 2022 · 1 comment

Comments

@asottile
Copy link
Member

asottile commented Nov 24, 2022 •
edited

I can't deal with another hundred duplicate issues -- be better open source users and read the changelog and search the issue tracker first

just to repeat the changes here since you're probably hitting one of these

--diff is gone

#1389

yes, it's broken by design, please don't try and re-litigate decisions that were made months ago it's very draining.

a better alternative is git diff --name-only -z --diff-filter=d -- '*.py' | xargs -0 flake8 or utilize pre-commit run --from-ref=... --to-ref=...

ValueError: Error code '#' supplied to 'ignore' option does not match '^[A-Z]{1,3}[0-9]{0,3}$'

#1750

surprise surprise! your configuration has been silently wrong for years -- it is now explicitly erroring on an invalid configuration setting!

please review the flake8 docs where a warning has been present for quite some time now (^F inline comments)

this fixes a long-standing easy to make mistake:

[flake8]
extend-ignore =
   E501  # using flake8-bugbear's B instead

this silently used to ignore B as well

TypeError: 'int' / 'choice / 'string' is not callable

for example #1751

the optparse support was removed. it has been deprecated and warning for 2+ years.

this is not a flake8 problem, report to whatever plugin is erroring (you can find their code in your stacktrace)

I have put together a helpful guide in the PR: #1739

anything else

please email me directly but please please please do some research first to make sure it's actually a problem
@asottile asottile pinned this issue Nov 24, 2022
This was referenced Nov 24, 2022
Merged
Closed
This was referenced Nov 25, 2022
Merged
Merged
@ymzayek ymzayek mentioned this issue Nov 25, 2022
Closed
@ericzolf ericzolf mentioned this issue Nov 25, 2022
Merged
3 tasks
davfsa added a commit to hikari-py/hikari that referenced this issue Nov 27, 2022
@davfsa
Remove in-line comments for ignore
85b1d25 
PyCQA/flake8#1760
wangenau added a commit to wangenau/eminus that referenced this issue Nov 28, 2022
@wangenau
Fix flake8 configuration, add reasoning to ignores
5d08a09 
* From PyCQA/flake8#1760:
  "surprise surprise! your configuration has been silently wrong for years"
@asottile
Copy link
Member Author

in case it's not clear, emailing me to debate these changes is not appropriate either and is part of the reason for the tracker being temporarily disabled

@kandersolar kandersolar mentioned this issue Nov 28, 2022
Closed
@Athanasius Athanasius mentioned this issue Nov 28, 2022
Closed
@jeffwidman jeffwidman mentioned this issue Nov 28, 2022
Open
@misl6 misl6 mentioned this issue Nov 28, 2022
Merged
@neutrinoceros neutrinoceros mentioned this issue Nov 28, 2022
Merged
@flying-sheep flying-sheep mentioned this issue Nov 29, 2022
Merged
This was referenced Nov 29, 2022
Merged
Closed
@di di mentioned this issue Nov 29, 2022
Closed
DimitriPapadopoulos added a commit to DimitriPapadopoulos/python-stdnum that referenced this issue Dec 1, 2022
@DimitriPapadopoulos
Plugin flake8-quotes is broken
7b85599 
PyCQA/flake8#1760
DimitriPapadopoulos added a commit to DimitriPapadopoulos/python-stdnum that referenced this issue Dec 1, 2022
@DimitriPapadopoulos
lugin flake8-quotes is broken
4858173 
PyCQA/flake8#1760
DimitriPapadopoulos added a commit to DimitriPapadopoulos/python-stdnum that referenced this issue Dec 1, 2022
@DimitriPapadopoulos
Plugin flake8-quotes is broken
5972aeb 
PyCQA/flake8#1760
DimitriPapadopoulos added a commit to DimitriPapadopoulos/python-stdnum that referenced this issue Dec 1, 2022
@DimitriPapadopoulos
Fix CI issues after flake8 update 5 → 6
3629e81 
Plugin flake8-quotes is broken

PyCQA/flake8#1760
DimitriPapadopoulos added a commit to DimitriPapadopoulos/python-stdnum that referenced this issue Dec 1, 2022
@DimitriPapadopoulos
Fix CI issues after flake8 update 5 → 6
54a9e51 
PyCQA/flake8#1760

* plugin flake8-quotes is broken
* setup.cfg syntax was incorrect
@DimitriPapadopoulos DimitriPapadopoulos mentioned this issue Dec 1, 2022
Closed
DimitriPapadopoulos added a commit to DimitriPapadopoulos/python-stdnum that referenced this issue Dec 1, 2022
@DimitriPapadopoulos
Fix CI issue after flake8 update 5 → 6
0414f4d 
PyCQA/flake8#1760

Fix incorrect `setup.cfg` syntax.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/python-stdnum that referenced this issue Dec 1, 2022
@DimitriPapadopoulos
Fix CI issue after flake8 update 5 → 6
a5e999a 
PyCQA/flake8#1760

Plugin flake8-quotes is currently incompatible with flake8 v6.
Work around by pinning flake8 until the flake8-quotes issue is fixed:
zheller/flake8-quotes#111 is merged.
@DimitriPapadopoulos DimitriPapadopoulos mentioned this issue Dec 1, 2022
Open
@johncrossman johncrossman mentioned this issue Dec 1, 2022
Merged
arthurdejong added a commit to arthurdejong/python-stdnum that referenced this issue Dec 3, 2022
@arthurdejong
Avoid newer flake8
7a91a98 
The new 6.0.0 contains a number of backwards incompatible changes
for which plugins need to be updated and configuration needs to be
updated.

Sadly the maintainer no longer accepts contributions or discussion
See PyCQA/flake8#1760
arthurdejong added a commit to arthurdejong/python-pskc that referenced this issue Dec 3, 2022
@arthurdejong
Avoid newer flake8
99422c0 
The new 6.0.0 contains a number of backwards incompatible changes
for which plugins need to be updated and configuration needs to be
updated.

Sadly the maintainer no longer accepts contributions or discussion
See PyCQA/flake8#1760
arthurdejong added a commit to arthurdejong/munin-plot that referenced this issue Dec 3, 2022
@arthurdejong
Avoid newer flake8
98fe1e5 
The new 6.0.0 contains a number of backwards incompatible changes
for which plugins need to be updated and configuration needs to be
updated.

Sadly the maintainer no longer accepts contributions or discussion
See PyCQA/flake8#1760
arthurdejong added a commit to arthurdejong/webchat that referenced this issue Dec 3, 2022
@arthurdejong
Avoid newer flake8
6cbdcd7 
The new 6.0.0 contains a number of backwards incompatible changes
for which plugins need to be updated and configuration needs to be
updated.

Sadly the maintainer no longer accepts contributions or discussion
See PyCQA/flake8#1760
huang06 added a commit to huang06/python-project-template that referenced this issue Dec 4, 2022
@huang06
fix: update config for newer flake8
37f504d 
<PyCQA/flake8#1760>
DimitriPapadopoulos added a commit to DimitriPapadopoulos/python-stdnum that referenced this issue Dec 5, 2022
@DimitriPapadopoulos
Fix CI issue after flake8 update 5 → 6
9339262 
PyCQA/flake8#1760

Fix incorrect `setup.cfg` syntax.
@misl6 misl6 mentioned this issue Dec 10, 2022
Merged
@asottile asottile unpinned this issue Dec 13, 2022
Xyene added a commit to DMOJ/judge-server that referenced this issue Dec 16, 2022
@Xyene
Fix flake8 update breaking CI
1f7e2b4 
Ref PyCQA/flake8#1760

👏 👏
Xyene added a commit to DMOJ/judge-server that referenced this issue Dec 16, 2022
@Xyene
ci: fix for flake8 6.0.0 breaking old configs
d3cbc91 
Ref PyCQA/flake8#1760

👏 👏
Xyene added a commit to DMOJ/judge-server that referenced this issue Dec 16, 2022
@Xyene
ci: fix for flake8 6.0.0 breaking old configs
802b3d3 
Ref PyCQA/flake8#1760

👏 👏
@misl6 misl6 mentioned this issue Jan 4, 2023
Merged
stefanv added a commit to stefanv/scipy that referenced this issue Jan 18, 2023
@stefanv
Add (optional) pre-commit hook
7dae194 
- Flake8 no longer handles patches, so instead apply to entire
  files (see PyCQA/flake8#1760)
- Rename `tools/lint_diff.py` to `tools/lint.py`
- Files can be obtained either via diffing against a branch,
  or by specifying them manually
- `tools/pre-commit-hook.sh` is a pre-commit hook that utilizes
  `tools/lint.py` but only lints staged changes
- Update contributor guidelines to point to pre-commit hook

See also the discussion at scipy#15489
stefanv added a commit to stefanv/scipy that referenced this issue Jan 18, 2023
@stefanv
Add (optional) pre-commit hook
786e11d 
- Flake8 no longer handles patches, so instead apply to entire
  files (see PyCQA/flake8#1760)
- Rename `tools/lint_diff.py` to `tools/lint.py`
- Files can be obtained either via diffing against a branch,
  or by specifying them manually
- `tools/pre-commit-hook.sh` is a pre-commit hook that utilizes
  `tools/lint.py` but only lints staged changes
- Update contributor guidelines to point to pre-commit hook

See also the discussion at scipy#15489
@stefanv stefanv mentioned this issue Jan 18, 2023
Merged
stefanv added a commit to stefanv/scipy that referenced this issue Jan 18, 2023
@stefanv
Add (optional) pre-commit hook
76ef708 
- Flake8 no longer handles patches, so instead apply to entire
  files (see PyCQA/flake8#1760)
- Rename `tools/lint_diff.py` to `tools/lint.py`
- Files can be obtained either via diffing against a branch,
  or by specifying them manually
- `tools/pre-commit-hook.sh` is a pre-commit hook that utilizes
  `tools/lint.py` but only lints staged changes
- Update contributor guidelines to point to pre-commit hook

See also the discussion at scipy#15489
StevenMaude added a commit to opensafely-core/ehrql that referenced this issue Feb 1, 2023
@StevenMaude
Reformat .flake8 configuration to not error
ec1f831 
This makes it look more like the examples in:

https://flake8.pycqa.org/en/6.0.0/user/configuration.html

The configuration was actually broken:

PyCQA/flake8#1760

Avoids:

```
ValueError: Error code '\\' supplied to 'ignore' option does not match '^[A-Z]{1,3}[0-9]{0,3}$'
```
@wenzeslaus wenzeslaus mentioned this issue May 23, 2023
Merged
wenzeslaus added a commit to wenzeslaus/grass that referenced this issue May 23, 2023
@wenzeslaus
contributing: Fix syntax in Flake8 config
dba4b8c 
Flake8 config file does not allow inline comments. Previous versions did not enforce that (which lead to silent errors), but the new versions (v6) do.

Source: PyCQA/flake8#1760
wenzeslaus added a commit to OSGeo/grass that referenced this issue May 24, 2023
@wenzeslaus
contributing: Fix syntax in Flake8 config (#2976)
1600a32 
Flake8 config file does not allow inline comments. Previous versions did not enforce that (which lead to silent errors), but the new versions (v6) do.

Source: PyCQA/flake8#1760
DimitriPapadopoulos added a commit to DimitriPapadopoulos/python-stdnum that referenced this issue Jun 18, 2023
@DimitriPapadopoulos
Fix CI issue after flake8 update 5 → 6
6665e45 
PyCQA/flake8#1760

Fix incorrect `setup.cfg` syntax.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/python-stdnum that referenced this issue Jun 18, 2023
@DimitriPapadopoulos
Fix CI issue after flake8 update 5 → 6
87b7782 
PyCQA/flake8#1760

Plugin flake8-quotes compatible with flake8 6.0 starting with 3.3.2:
zheller/flake8-quotes#111 is merged.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/python-stdnum that referenced this issue Jun 18, 2023
@DimitriPapadopoulos
Fix CI issue after flake8 update 5 → 6
2865cc9 
PyCQA/flake8#1760

Plugin flake8-quotes is now compatible with flake8 6.0,
starting with release 3.3.2:
zheller/flake8-quotes#111 is merged.
@wenzeslaus wenzeslaus mentioned this issue Jul 11, 2023
Merged
wenzeslaus added a commit to wenzeslaus/grass-addons that referenced this issue Jul 11, 2023
@wenzeslaus
checks: Fix syntax in Flake8 config
669a19f 
Flake8 config file does not allow inline comments. Previous versions did not enforce that (which lead to silent errors), but the new versions (v6) do.

Source: PyCQA/flake8#1760

In core repo: OSGeo/grass#2976
wenzeslaus added a commit to OSGeo/grass-addons that referenced this issue Jul 18, 2023
@wenzeslaus
checks: Fix syntax in Flake8 config (#932)
47b7b9f 
Flake8 config file does not allow inline comments. Previous versions did not enforce that (which lead to silent errors), but the new versions (v6) do.

Source: PyCQA/flake8#1760

In core repo: OSGeo/grass#2976
cwhite911 pushed a commit to cwhite911/grass-addons that referenced this issue Sep 19, 2023
@wenzeslaus
checks: Fix syntax in Flake8 config (OSGeo#932)
ec00689 
Flake8 config file does not allow inline comments. Previous versions did not enforce that (which lead to silent errors), but the new versions (v6) do.

Source: PyCQA/flake8#1760

In core repo: OSGeo/grass#2976
neteler pushed a commit to nilason/grass that referenced this issue Nov 7, 2023
@wenzeslaus @neteler
contributing: Fix syntax in Flake8 config (OSGeo#2976)
23fdf2d 
Flake8 config file does not allow inline comments. Previous versions did not enforce that (which lead to silent errors), but the new versions (v6) do.

Source: PyCQA/flake8#1760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asottile