Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure the linter to only check lines of code that change for new PR's #169

Closed
kperrynrel opened this issue Nov 22, 2022 · 2 comments · Fixed by #171
Closed

Configure the linter to only check lines of code that change for new PR's #169

kperrynrel opened this issue Nov 22, 2022 · 2 comments · Fixed by #171
Assignees
Milestone

Comments

@kperrynrel
Copy link
Collaborator

Right now I have a PR that is failing from a previously pushed PR pep8 error (see irradiance module in #162). This PEP8 issue is deliberate as it errors on URL text in the docstring that we want to keep. @kanderso-nrel mentioned pvlib-python overrides previous PR issues in main (that are deliberate) when making new PR's by configuring the linter to only check lines of code that changed.

@wholmgren
Copy link
Member

flake8 deprecated the diff option. For new/young projects the recommendation is to configure the linter to fail on all errors. It's much more robust that checking the diff.

@kandersolar
Copy link
Member

I think adding a few noqa comments is fine for now. If someday it does make sense to switch to only linting the diff (which I agree is complicated), the suggestions here are a place to start: PyCQA/flake8#1760 (comment)

@kandersolar kandersolar added this to the v0.1.3 milestone Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants