You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now I have a PR that is failing from a previously pushed PR pep8 error (see irradiance module in #162). This PEP8 issue is deliberate as it errors on URL text in the docstring that we want to keep. @kanderso-nrel mentioned pvlib-python overrides previous PR issues in main (that are deliberate) when making new PR's by configuring the linter to only check lines of code that changed.
The text was updated successfully, but these errors were encountered:
flake8 deprecated the diff option. For new/young projects the recommendation is to configure the linter to fail on all errors. It's much more robust that checking the diff.
I think adding a few noqa comments is fine for now. If someday it does make sense to switch to only linting the diff (which I agree is complicated), the suggestions here are a place to start: PyCQA/flake8#1760 (comment)
Right now I have a PR that is failing from a previously pushed PR pep8 error (see irradiance module in #162). This PEP8 issue is deliberate as it errors on URL text in the docstring that we want to keep. @kanderso-nrel mentioned pvlib-python overrides previous PR issues in main (that are deliberate) when making new PR's by configuring the linter to only check lines of code that changed.
The text was updated successfully, but these errors were encountered: