Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese language translation #1225

Merged
merged 5 commits into from Dec 6, 2022

Conversation

soramikan
Copy link
Contributor

@soramikan soramikan commented Nov 28, 2022

Fixes #

Description of the Change

Japanese translation added.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #1225 (42976c7) into master (c4fe071) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1225   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          26       26           
  Lines        1317     1317           
=======================================
  Hits         1267     1267           
  Misses         50       50           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@soramikan
Copy link
Contributor Author

I don't know why the 3.8 test fails when I didn't edit the code itself, just the i18n .po file.
Is there something else wrong?

@n2ygk
Copy link
Member

n2ygk commented Nov 29, 2022

I don't know why the 3.8 test fails when I didn't edit the code itself, just the i18n .po file. Is there something else wrong?

Yes there is. I just haven't had the time to see what broke and why it only manifests now when running tests for a PR that doesn't touch any code.

@n2ygk
Copy link
Member

n2ygk commented Nov 29, 2022

Looks like a flake8 issue since tox.ini doesn't pin the version: PyCQA/flake8#1760

@n2ygk
Copy link
Member

n2ygk commented Nov 29, 2022

See #1226

@soramikan
Copy link
Contributor Author

Thanks to the upstream commitments, the test is now a success. Thank you!

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@n2ygk n2ygk merged commit bf4afd4 into jazzband:master Dec 6, 2022
@n2ygk n2ygk added this to the Future milestone Feb 12, 2023
@n2ygk n2ygk modified the milestones: Future, 2.3.0 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants