New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI issues after flake8 update 5 → 6 #343
Fix CI issues after flake8 update 5 → 6 #343
Conversation
For now I've pushed 7a91a98 to keep the working flake8. I'm not happy about the dropping of support for inline comments in the ignore list in flake8 because it makes the ignore list much more difficult to manage and I'm hoping the support for comments will be restored at some point. |
Support for comments will not be restored. Such comments are considered to be a syntax error. See PyCQA/flake8#1750. |
I've seen those comments and I think they are wrong. ;) Similar inline comments are supported in a lot of places in tox.ini or setup.cfg so I don't see why a list of ignores in flake8 is so special that we should expect different behaviour. |
If the maintainer thinks otherwise, this will not be fixed. We need arguments from the documentation or normative documents such as PEPs. The Python Packaging User Guide doesn't say much on the subject:
The Python documentation, in Syntax of config files, is even less informative:
Unfortunately, INI files lack a real standard. From Wikipedia:
|
a5e999a
to
9339262
Compare
PyCQA/flake8#1760 Fix incorrect `setup.cfg` syntax.
9339262
to
87b7782
Compare
PyCQA/flake8#1760 Plugin flake8-quotes is now compatible with flake8 6.0, starting with release 3.3.2: zheller/flake8-quotes#111 is merged.
87b7782
to
2865cc9
Compare
Update to require I don't know how to require this version only for |
PyCQA/flake8#1760
setup.cfg
syntax.Fixes #342.