Fix recognition of remote Windows OS #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX: failed to properly recognize remote OS as being Windows, closes #788 Also reduced a bit the impact of the previous change, because a normal exception might be catched at the file level, whereas FatalError would always exit Modify comparetest.py to use new feature.
ikus060
reviewed
Nov 25, 2022
ikus060
reviewed
Nov 25, 2022
This was referenced Nov 26, 2022
Checking first for directory type and then for Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done and why
FIX: failed to properly recognize remote OS as being Windows, closes #788
Also reduced a bit the impact of the previous change, because a normal exception might be catched at the file level, whereas FatalError would always exit
Modify comparetest.py to use new feature. Allow remote parts of comparetest to work under Windows
Checklist