[FIX] Flake8 latest release raises error and includes backwards incompatilble change

[ymzayek]

Closes #3431. Flake8 just released a new version that raises a PEP8 failure in our CI check. Also the --diff option is now removed so we have to handle differently how we pipe changes for flake8 to check.
See: https://flake8.pycqa.org/en/latest/release-notes/6.0.0.html#backwards-incompatible-changes

[github-actions]

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

• PR has an interpretable title.
• PR links to Github issue with mention "Closes #XXXX"
• Code is PEP8-compliant.
• (Bug fixes) There is at least one test that would fail under the original bug conditions.
• (New features) There is at least one unit test per new function / class.
• (New features) The new feature is demoed in at least one relevant example.

We will review it as quick as possible, feel free to ping us with questions if needed.

[codecov]

Codecov Report

Merging #3420 (781af0b) into main (109f4a6) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3420      +/-   ##
==========================================
- Coverage   90.93%   90.72%   -0.22%     
==========================================
  Files         133      128       -5     
  Lines       15399    15003     -396     
  Branches     3123     3074      -49     
==========================================
- Hits        14003    13611     -392     
+ Misses        825      822       -3     
+ Partials      571      570       -1     

Impacted Files	Coverage Δ
...ces/fmriprep/tests/test_load_confounds_strategy.py
...rfaces/fmriprep/tests/test_load_confounds_utils.py
nilearn/interfaces/fmriprep/tests/utils.py
...n/interfaces/fmriprep/tests/test_load_confounds.py
...rfaces/fmriprep/tests/test_load_confounds_scrub.py

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[bthirion]

There is still a flake8 error due to --diff option.

[ymzayek]

Yes, sorry I haven't had time to look into it. I will change this to a draft until it's ready.

[ymzayek]

I changed the flake8 --diff command to what is suggested on this thread: PyCQA/flake8#1760
The problem now is that flake8 will be run on entire changed files instead of just the diff. Do we want this? If we implement automatic formatting discussed in #2528, then it won't be a problem. But I'm just worried the transition will be painful. Any alternative suggestions welcome.

[jeromedockes]

I changed the `flake8 --diff` command to what is suggested on this thread: PyCQA/flake8#1760 The problem now is that flake8 will be run on entire changed files instead of just the diff. Do we want this? If we implement automatic formatting discussed in #2528, then it won't be a problem.

I would say no, and we can revisit when automatic formatting is in place

[ymzayek]

Yes agreed. I will stall this then

[ymzayek]

BTW a short term solution here can be just to use a previous version of flake8 in our PEP8 check. Any opinions on that?

[bthirion]

rather -1 on my side. Rather use up-to-date tools.

[jeromedockes]

does #3420 (comment) mean we should remove flake8 check entirely for now?

[ymzayek]

We could since we cannot use it in the way we want. I just stalled it while waiting for a better solution but if the only solution will be implementing automatic formatting then we won't need this I guess

[ymzayek]

Closing this since it's superseded by #3484