Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for flake8 6.0 #1181

Merged
merged 1 commit into from Nov 25, 2022
Merged

Fixes for flake8 6.0 #1181

merged 1 commit into from Nov 25, 2022

Conversation

araffin
Copy link
Member

@araffin araffin commented Nov 25, 2022

Description

See PyCQA/flake8#1760 and DLR-RM/rl-baselines3-zoo#318

I also create a branch to improve error message: https://github.com/PyCQA/flake8/compare/main...araffin:flake8:fix/improve-error-message?expand=1

I fixed the additional warnings that were raised.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@qgallouedec qgallouedec merged commit cd630a3 into master Nov 25, 2022
@qgallouedec qgallouedec deleted the fix/flake8-6 branch November 25, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants