Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.28.2 to 1.34.0 #244

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 9, 2022

Bumps rubocop from 1.28.2 to 1.34.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.34

New features

Bug fixes

  • #10552: Require RuboCop AST 1.20.0+ to fix a false positive for Lint/OutOfRangeRegexpRef when using fixed-encoding regopt. (@​koic)
  • #10512: Fix a false positive for Lint/ShadowingOuterLocalVariable conditional statement and block variable. (@​ydah)
  • #10864: min and max results in false positives for Style/SymbolProc similarly to select and reject. (@​mollerhoj)
  • #10846: Fix a false negative for Style/DoubleNegation when there is a hash or an array at return location of method. (@​nobuyo)
  • #10875: Fix an obsolete option configuration values are duplicated when generating .rubocop_todo.yml. (@​ydah)
  • #10877: Fix crash with Layout/BlockEndNewline heredoc detection. (@​dvandersluis)
  • #10859: Fix Lint/Debugger to be able to handle method chains correctly. (@​dvandersluis)
  • #10883: Fix Style/RedundantParentheses to be able to detect offenses and properly correct when the end parentheses and comma are on their own line. (@​dvandersluis)
  • #10881: Fix Style/SoleNestedConditional to properly wrap block and csend nodes when necessary. (@​dvandersluis)
  • #10867: Mark autocorrection for Lint/EmptyConditionalBody as unsafe. (@​dvandersluis)
  • #10871: Restore RuboCop::ConfigLoader.project_root as deprecated. (@​koic)

Changes

RuboCop 1.33

Bug fixes

  • #10830: Fix an incorrect autocorrect for Layout/FirstArgumentIndentation when specifying EnforcedStyle: with_fixed_indentation of Layout/ArgumentAlignment and EnforcedStyle: consistent of Layout/FirstArgumentIndentation and enabling Layout/FirstMethodArgumentLineBreak. (@​koic)
  • #10825: Fix an incorrect autocorrect for Style/ClassAndModuleChildren when using nested one-liner class. (@​koic)
  • #10843: Fix a false positive for Style/HashExcept when using reject and calling include? method with symbol array and second block value. (@​koic)
  • #10853: Fix an autocorrect for Style/RedundantSort with logical operator. (@​ydah)
  • #10842: Make server mode aware of CacheRootDirectory config option value, RUBOCOP_CACHE_ROOT, and XDG_CACHE_HOME environment variables. (@​koic)
  • #10833: Fix an incorrect autocorrect for Style/RedundantCondition when branches contains arithmetic operation. (@​koic)
  • #10864: Fix a false positive for Style/SymbolProc when using Hash#reject. (@​koic)
  • #10771: Make server mode aware of --cache-root command line option. (@​koic)
  • #10831: Fix an error when using changed_parameters in obsoletion.yml by external library. (@​koic)
  • #10850: Fix Style/ClassEqualityComparison autocorrection within module. (@​r7kamura)
  • #10832: Fix an incorrect autocorrect for Layout/BlockEndNewline when multiline block } is not on its own line and using heredoc argument. (@​koic)

Changes

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.34.0 (2022-08-09)

New features

Bug fixes

  • #10552: Require RuboCop AST 1.20.0+ to fix a false positive for Lint/OutOfRangeRegexpRef when using fixed-encoding regopt. ([@​koic][])
  • #10512: Fix a false positive for Lint/ShadowingOuterLocalVariable conditional statement and block variable. ([@​ydah][])
  • #10864: min and max results in false positives for Style/SymbolProc similarly to select and reject. ([@​mollerhoj][])
  • #10846: Fix a false negative for Style/DoubleNegation when there is a hash or an array at return location of method. ([@​nobuyo][])
  • #10875: Fix an obsolete option configuration values are duplicated when generating .rubocop_todo.yml. ([@​ydah][])
  • #10877: Fix crash with Layout/BlockEndNewline heredoc detection. ([@​dvandersluis][])
  • #10859: Fix Lint/Debugger to be able to handle method chains correctly. ([@​dvandersluis][])
  • #10883: Fix Style/RedundantParentheses to be able to detect offenses and properly correct when the end parentheses and comma are on their own line. ([@​dvandersluis][])
  • #10881: Fix Style/SoleNestedConditional to properly wrap block and csend nodes when necessary. ([@​dvandersluis][])
  • #10867: Mark autocorrection for Lint/EmptyConditionalBody as unsafe. ([@​dvandersluis][])
  • #10871: Restore RuboCop::ConfigLoader.project_root as deprecated. ([@​koic][])

Changes

1.33.0 (2022-08-04)

Bug fixes

  • #10830: Fix an incorrect autocorrect for Layout/FirstArgumentIndentation when specifying EnforcedStyle: with_fixed_indentation of Layout/ArgumentAlignment and EnforcedStyle: consistent of Layout/FirstArgumentIndentation and enabling Layout/FirstMethodArgumentLineBreak. ([@​koic][])
  • #10825: Fix an incorrect autocorrect for Style/ClassAndModuleChildren when using nested one-liner class. ([@​koic][])
  • #10843: Fix a false positive for Style/HashExcept when using reject and calling include? method with symbol array and second block value. ([@​koic][])
  • #10853: Fix an autocorrect for Style/RedundantSort with logical operator. ([@​ydah][])
  • #10842: Make server mode aware of CacheRootDirectory config option value, RUBOCOP_CACHE_ROOT, and XDG_CACHE_HOME environment variables. ([@​koic][])
  • #10833: Fix an incorrect autocorrect for Style/RedundantCondition when branches contains arithmetic operation. ([@​koic][])
  • #10864: Fix a false positive for Style/SymbolProc when using Hash#reject. ([@​koic][])
  • #10771: Make server mode aware of --cache-root command line option. ([@​koic][])
  • #10831: Fix an error when using changed_parameters in obsoletion.yml by external library. ([@​koic][])
  • #10850: Fix Style/ClassEqualityComparison autocorrection within module. ([@​r7kamura][])
  • #10832: Fix an incorrect autocorrect for Layout/BlockEndNewline when multiline block } is not on its own line and using heredoc argument. ([@​koic][])

Changes

  • #10841: Don't hash shared libraries for cache key. ([@​ChrisBr][])
  • #10862: Add autocorrection to Lint/EmptyConditionalBody. ([@​dvandersluis][])
  • #10829: Deprecate IgnoredMethods option in favor of the AllowedMethods and AllowedPatterns options. ([@​ydah][])

... (truncated)

Commits
  • a407f64 Cut 1.34
  • 01c3b20 Update Changelog
  • 1db2aae Support Bundler-like namespaced feature on require config
  • 88af469 Merge pull request #10886 from dvandersluis/issue/10881
  • 67f3055 Merge pull request #10885 from dvandersluis/issue/10883
  • 838ec41 [Fix #10883] Fix Style/RedundantParentheses to be able to detect offenses a...
  • 64cdfad [Fix #10881] Fix Style/SoleNestedConditional to properly wrap block and `...
  • eaec469 Merge pull request #10887 from dvandersluis/lint/shadowed-exception
  • f304479 Merge pull request #10888 from dvandersluis/issue/10773
  • 2ace9ef [Fix #10773] Update parser gem to >= 3.1.2.1.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.28.2 to 1.34.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.28.2...v1.34.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 9, 2022
@ShockwaveNN
Copy link
Contributor

Blocked by rubocop/rubocop#10893

@ShockwaveNN ShockwaveNN closed this Aug 9, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 9, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@ShockwaveNN ShockwaveNN deleted the dependabot/bundler/rubocop-1.34.0 branch August 9, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant