Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error when using changed_parameters by external library #10831

Conversation

koic
Copy link
Member

@koic koic commented Jul 24, 2022

This PR fixes the following error when using changed_parameters in obsoletion.yml by external library.

NoMethodError: undefined method `merge' for
[{"cops"=>["Layout/SpaceAroundOperators", "Style/SpaceAroundOperators"],
"parameters"=>"MultiSpaceAllowedForOperators", "reason"=>"If your
intention was to allow extra spaces for alignment, please use `AllowFoy

          first.merge(second)
               ^^^^^^
/Users/koic/src/github.com/rubocop/rubocop-rails/lib/rubocop/rails/inject.rb:11:in `new'
/Users/koic/src/github.com/rubocop/rubocop-rails/lib/rubocop/rails/inject.rb:11:in `defaults!'
/Users/koic/src/github.com/rubocop/rubocop-rails/lib/rubocop-rails.rb:13:in `<top (required)>'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic changed the title Fix an error when using changed_parameters by an external library Fix an error when using changed_parameters by external library Jul 24, 2022
@koic koic force-pushed the fix_an_error_when_using_changed_parameters_by_external_library branch from b7d6d3b to 9c6f833 Compare July 24, 2022 16:14
This PR fixes the following error when using `changed_parameters` in obsoletion.yml
by external library.

```console
NoMethodError: undefined method `merge' for
[{"cops"=>["Layout/SpaceAroundOperators", "Style/SpaceAroundOperators"],
"parameters"=>"MultiSpaceAllowedForOperators", "reason"=>"If your
intention was to allow extra spaces for alignment, please use `AllowFoy

          first.merge(second)
               ^^^^^^
/Users/koic/src/github.com/rubocop/rubocop-rails/lib/rubocop/rails/inject.rb:11:in `new'
/Users/koic/src/github.com/rubocop/rubocop-rails/lib/rubocop/rails/inject.rb:11:in `defaults!'
/Users/koic/src/github.com/rubocop/rubocop-rails/lib/rubocop-rails.rb:13:in `<top (required)>'
```
@koic koic force-pushed the fix_an_error_when_using_changed_parameters_by_external_library branch from 9c6f833 to dd9c99e Compare July 24, 2022 16:40
@koic koic merged commit 20990ed into rubocop:master Jul 25, 2022
@koic koic deleted the fix_an_error_when_using_changed_parameters_by_external_library branch July 25, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant