[Fix #10881] Fix Style/SoleNestedConditional to properly wrap block and csend nodes when necessary
#10886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Aug 9, 2022
| RUBY | ||
|
|
||
| expect_correction(<<~RUBY) | ||
| if foo && (bar&.baz quux) |
There was a problem hiding this comment.
It would be more better to correct as follows.
Suggested change
| if foo && (bar&.baz quux) | |
| if foo && bar&.baz(quux) |
There was a problem hiding this comment.
I agree, but this is the existing autocorrection for send nodes I'm just extending it to csend and block nodes as well to prevent syntax errors from autocorrection.
Would you be good with accepting this as-is and improving autocorrection in a future PR?
There was a problem hiding this comment.
OK, I think we can do it separately. It would be useful to leave a FIXME comment.
koic
reviewed
Aug 9, 2022
Comment on lines
+699
to
+702
| if foo && (ok? bar do | ||
| do_something | ||
| end) | ||
| end |
There was a problem hiding this comment.
Ditto :-)
Suggested change
| if foo && (ok? bar do | |
| do_something | |
| end) | |
| end | |
| if foo && ok?(bar) do | |
| do_something | |
| end | |
| end |
…p `block` and `csend` nodes when necessary.
dvandersluis
force-pushed
the
issue/10881
branch
from
37dfae6
to
64cdfad
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style/SoleNestedConditionaladds parentheses aroundsendnodes that have unparenthesized arguments, but this wasn't being done forcsendorblocknodes, so this change fixes that.Fixes #10881.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.