Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Style/ClassEqualityComparison autocorrection within module #10850

Merged

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Aug 1, 2022

In the situation where Module.nesting is not empty, bar.class.name == 'Bar' and bar.instance_of?(Bar) yield different results.

This is a simple example of the problematic case:
(In reality, it is more complicated because constant search is done by tracing back to ancestor inheritance tree)

module Foo
  class << self
    def bar1?(value)
      value.instance_of?(Bar)
    end

    def bar2?(value)
      value.class.name == 'Bar'
    end
  end

  class Bar
  end
end

class Bar
end

p Foo.bar1?(Bar.new) #=> false
p Foo.bar1?(Foo::Bar.new) #=> true

p Foo.bar2?(Bar.new) #=> true
p Foo.bar2?(Foo::Bar.new) #=> false

So I changed it to prepend :: in those situations.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic merged commit e9553ad into rubocop:master Aug 1, 2022
@koic
Copy link
Member

koic commented Aug 1, 2022

Good catch! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants