[Fix #10883] Fix Style/RedundantParentheses
to be able to detect offenses and properly correct when the end parentheses and comma are on their own line
#10885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in #2874 / #3078,
Style/RedundantParentheses
was updated to ignore parentheses in arrays when the comma is on a separate line with the end parenthesis, as that would leave a comma on a line by itself, which is a syntax error.Additionally, this trailing comma problem shows up in method argument lists, hashes, etc.
This change removes the false negative for this situation, and instead updates
ParenthesesCorrector
to be able to handle commas that are orphaned onto their own line after removing parentheses. Note that this corrector is also used byStyle/ParenthesesAroundCondition
andStyle/RescueModifier
but all tests are passing without change.Fixes #10883.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.