Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Review and merge #7101

Closed
14 of 21 tasks
shilman opened this issue Jun 16, 2019 · 12 comments
Closed
14 of 21 tasks

Addon-docs: Review and merge #7101

shilman opened this issue Jun 16, 2019 · 12 comments
Assignees
Labels
addon: docs maintenance User-facing maintenance tasks
Milestone

Comments

@shilman
Copy link
Member

shilman commented Jun 16, 2019

SB Docs is a big new Storybook feature that has been developed and released as 5.2.0-alpha.x from the https://github.com/storybookjs/storybook/tree/release/docs-technical-preview branch.

Now we're in a tricky situation where we need to get this work merged back into next. Rather than a single giant merge, I'm going to break the work into a series of small PRs that can be properly reviewed and refined. This umbrella issue tracks that work.

Addon PRs

Example PRs

@shilman
Copy link
Member Author

shilman commented Jun 25, 2019

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-alpha.30 containing PR #7171 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jun 25, 2019
@shilman shilman reopened this Jun 25, 2019
@damusix
Copy link

damusix commented Jun 26, 2019

Hey @shilman, not sure if you are aware, but currently Riot has been upgraded to version 4, and it is not compatible with Riot 3. Lot of the dependencies currently in Storybook/Riot will not work with Riot 4. If you'd like to see an example of Riot4 with webpack, I have one in my boilerplate project. Check out how the dependencies are now different.

I really like story book and I really like Riot. Would love to see them work together. Also, if there's anything I can do to help, feel free to ask!

@shilman
Copy link
Member Author

shilman commented Jun 26, 2019

@damusix Please open a separate issue about Riot4 support. Hopefully someone will pick it up!

@shilman
Copy link
Member Author

shilman commented Jul 15, 2019

Shiver me timbers!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.0 containing PR #7418 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman
Copy link
Member Author

shilman commented Jul 18, 2019

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.2 containing PR #7454 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jul 18, 2019
@shilman shilman reopened this Jul 19, 2019
@shilman shilman modified the milestones: 5.2.0, 5.2.x Sep 23, 2019
@ux-engineer
Copy link

I don't think Vue kitchen sink example is done yet because there is no TypeScript configured in that example.

With Vue 3.0 approaching, people should already be using TypeScript in their Vue projects, and it seems this not straightforward setup to configure when using addon-docs, ref #8082

@ux-engineer
Copy link

In addition, please note that by default Vue projects are configured to use '@' as an Webpack alias to point to /src folder, so this should be configured as well.

@shilman
Copy link
Member Author

shilman commented Oct 15, 2019

@envision would you mind filing a separate issue containing Vue improvements you'd like to see? I'm working with @Aaron-Pool and @elevatebart to get official Vue support ready in 5.3. This issue is just about getting the alpha merged, which is done

@shilman
Copy link
Member Author

shilman commented Oct 15, 2019

@envision #8082 seems like a good place to aggregate this

@shilman
Copy link
Member Author

shilman commented Oct 19, 2019

Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-alpha.23 containing PR #7668 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Oct 19, 2019
@shilman shilman reopened this Oct 19, 2019
@shilman
Copy link
Member Author

shilman commented Nov 7, 2019

Closing this and will follow up with individual issues as needed

@shilman shilman closed this as completed Nov 7, 2019
@shilman
Copy link
Member Author

shilman commented Mar 12, 2020

Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.26 containing PR #7673 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs maintenance User-facing maintenance tasks
Projects
None yet
Development

No branches or pull requests

3 participants