Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Convert angular-cli stories to CSF #7668

Merged
merged 4 commits into from Oct 18, 2019
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 3, 2019

Issue: #7101

What I did

Ran sb migrate storieof-to-csf and minor touchup

How to test

cd examples/angular-cli
yarn storybook

@vercel
Copy link

vercel bot commented Aug 3, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/9ne7rj16p
🌍 Preview: https://monorepo-git-7101-angular-example-to-csf.storybook.now.sh

@shilman shilman added maintenance User-facing maintenance tasks and removed documentation labels Aug 3, 2019
@shilman shilman added this to the 5.2.0 milestone Aug 3, 2019
},
});

actionOnly.story = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to type this? In strict: true you most likely have to
export const actionOnly: any in order to call .story

Maybe actionOnly: Story = () => { ... }?

Copy link
Member Author

@shilman shilman Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kroeder great idea! #7677

@shilman
Copy link
Member Author

shilman commented Aug 5, 2019

@igor-dv angularshots seems to be failing on this PR and i can repro on my dev machine. any chance you can take a look for me? i think it's angular-specific since official-storybook is also using CSF & typescript successfully.

@stale stale bot added the inactive label Aug 26, 2019
@shilman shilman modified the milestones: 5.2.0, 5.2.x Sep 23, 2019
@stale stale bot removed the inactive label Sep 23, 2019
@storybookjs storybookjs deleted a comment from stale bot Sep 24, 2019
@ndelangen
Copy link
Member

Would be great to be able to merge this, @shilman @kroeder @igor-dv @alterx ?

@ndelangen ndelangen self-assigned this Sep 24, 2019
@shilman
Copy link
Member Author

shilman commented Oct 18, 2019

Self-merging

@shilman shilman merged commit d813f52 into next Oct 18, 2019
@shilman shilman deleted the 7101-angular-example-to-csf branch October 18, 2019 02:51
@shilman shilman mentioned this pull request Oct 19, 2019
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular csf maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants