Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-Docs: HTML support & example #7454

Merged
merged 2 commits into from Jul 18, 2019
Merged

Addon-Docs: HTML support & example #7454

merged 2 commits into from Jul 18, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 17, 2019 •
edited

Issue: #7101

What I did

  • Add HTML preset to addon-docs (that just uses the common one)
  • Add DocsPage and MDX example to html-kitchen-sink

How to test

cd examples/html-kitchen-sink
yarn storybook

Or just check out the deployed storybook below

@vercel
Copy link

vercel bot commented Jul 17, 2019 •
edited

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-7101-html-docs-example.storybook.now.sh

@shilman shilman added this to the 5.2.0 milestone Jul 17, 2019
@shilman shilman requested a review from tmeasday July 18, 2019 04:42
tmeasday
tmeasday approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 13eb0cf into next Jul 18, 2019
@shilman shilman deleted the 7101-html-docs-example branch July 18, 2019 05:58
@shilman shilman mentioned this pull request Jul 18, 2019
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hypnosphi Hypnosphi Hypnosphi left review comments

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
addon: docs feature request html
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shilman @tmeasday @Hypnosphi