Addon-docs: Fix non-React support & add Vue example #7222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-7101-vue-docs-mode.storybook.now.sh |
shilman
changed the title
ndelangen
reviewed
Jul 1, 2019
ndelangen
approved these changes
Jul 1, 2019
shilman
changed the title
shilman
changed the title
shilman
changed the title
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7101
What I did
Add docs to
vue-kitchen-sinkto show off cross-framework docs supportThis also addresses a bug in SB docs rendering conflicting with the vue renderer by rendering the docs into its own DOM root.
Bug: click back and forth between Canvas and Docs tabs. It will get stuck on one view. Sometimes there will be an error in the browser console depending on what story you're viewing, relating to_addonsin the subscription store. I don't think it's related to theviewModeproblem.