Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'Show Info' button in info addon #6420

Closed
Glazy opened this issue Apr 4, 2019 · 11 comments
Closed

Move 'Show Info' button in info addon #6420

Glazy opened this issue Apr 4, 2019 · 11 comments

Comments

@Glazy
Copy link
Contributor

Glazy commented Apr 4, 2019

Is your feature request related to a problem? Please describe.

When using @storybook/addon-info the 'Show Info' button at the top right of the component view area overlays the rendered component. This was a problem when we had a full-width component that had an icon on the right hand side that was being covered by the button.

Describe the solution you'd like

It would be nice to make use of Storybooks built-in top bar area. Take a look at the screenshot below 👇

Screen Shot 2019-04-04 at 15 31 58

Describe alternatives you've considered

There could potentially be a way to toggle this 'Show Info' button but I think the solution I've suggested above is the better fix.

Are you able to assist bring the feature to reality?

Yes

@shilman
Copy link
Member

shilman commented Apr 4, 2019

Cool idea! I think this would be a nice improvement for addon-info 👍

@Armanio
Copy link
Member

Armanio commented Apr 14, 2019

Hey @Glazy! I like it, it will decide any problem with 'info' toggle.
Are you have progress? I can help you? Let me know.

@joeycozza
Copy link
Contributor

joeycozza commented Apr 16, 2019

I'd also like to throw in the idea of a flag to put addon-info as a Panel (instead of a Tab which was suggested above). So I guess the options would be

  1. inline (currently exists)
  2. wrapping the content with the little button on the top right (currently exists)
  3. tab
  4. panel

@techieshark
Copy link
Contributor

@joeycozza I think I've seen the idea of changing addon-info in related manner mentioned in other issues (assuming I'm understanding the proposals correctly):

#1147 (comment)
#6049 (comment)

cc @shilman

@stale
Copy link

stale bot commented May 17, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 17, 2019
@shilman
Copy link
Member

shilman commented May 17, 2019

FYI just wrapping up the technical preview of addon-docs which aims to replace addon-info and addresses these issues: https://medium.com/storybookjs/storybook-docs-sneak-peak-5be78445094a

Discussion in the #docs-mode channel in our Discord https://discord.gg/UUt2PJb

@stale stale bot removed the inactive label May 17, 2019
@stale
Copy link

stale bot commented Jun 7, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jun 7, 2019
@jamime
Copy link

jamime commented Jun 18, 2019

PR for addon-docs #7101

@stale stale bot removed the inactive label Jun 18, 2019
@shilman
Copy link
Member

shilman commented Jun 18, 2019

@jamime FYI it's been out as 5.2.0-alpha.x for the past month. Guide: https://docs.google.com/document/d/1un6YX7xDKEKl5-MVb-egnOYN8dynb5Hf7mq0hipk8JE/edit?usp=sharing

@stale
Copy link

stale bot commented Jul 9, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 9, 2019
@stale
Copy link

stale bot commented Aug 8, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants