Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Svelte example #7673

Merged
merged 12 commits into from Mar 12, 2020
Merged

Addon-docs: Svelte example #7673

merged 12 commits into from Mar 12, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 4, 2019 •
edited

Issue: #7101

What I did

  • Svelte preset
  • Add to svelte-kitchen-sink
  • Temporarily disable source-loader due to loading bug
  • Add working MDX example

How to test

cd examples/svelte-kitchen-sink
yarn storybook

@shilman shilman added this to the 5.2.0 milestone Aug 4, 2019
@vercel
Copy link

vercel bot commented Aug 4, 2019 •
edited

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-7101-docs-svelte-preset.storybook.now.sh

@stale stale bot added the inactive label Aug 26, 2019
@stale stale bot removed the inactive label Aug 26, 2019
@vercel vercel bot temporarily deployed to staging August 27, 2019 03:56 Inactive
@stale
Copy link

stale bot commented Sep 17, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Sep 17, 2019
@stale stale bot removed the inactive label Sep 17, 2019
@storybookjs storybookjs deleted a comment from stale bot Sep 17, 2019
@shilman shilman modified the milestones: 5.2.0, 5.2.x Sep 23, 2019
@mikenikles
Copy link

This would be useful for a component library I'm working on. Is there anything I can help with to get this merged?

@shilman shilman modified the milestones: 5.2.x, 5.4.0 Nov 13, 2019
@shilman shilman modified the milestones: 5.4.0, 6.0.0 Dec 16, 2019
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2020 •
edited

Fails
🚫 PR is marked with "in progress" label.

Generated by 🚫 dangerJS against 70c3ac7

@shilman
Copy link
Member Author

shilman commented Mar 12, 2020

Merging based on review from @digitalclubb on discord 💯

@shilman shilman changed the title Addon-docs: DocsPage partial svelte support Addon-docs: Svelte example Mar 12, 2020
@shilman shilman merged commit dd864e4 into next Mar 12, 2020
@shilman shilman deleted the 7101-docs-svelte-preset branch March 12, 2020 02:05
@shilman shilman mentioned this pull request Mar 12, 2020
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@rixo rixo

Labels
addon: docs feature request svelte
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shilman @mikenikles @rixo