[v.1.13.1] Release Tracker

[atalman]

We cut a release branch for the 1.13.1 release.

Our plan from this point from this point is roughly:

• Phase 1 (until 12/8): Release Candidate 1
• Phase 2 (until 12/15): Tentative General Availability

This issue is for tracking cherry-picks to the release branch.

Cherry-Pick Criteria

Phase 1 (until 12/8/2022):

Only low-risk changes may be cherry-picked from master:

1. Fixes to regressions against previous major version (e.g. regressions introduced in 1.13.0 from 1.12.0 are pickable for 1.13.1)
2. Critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
3. Fixes to new features being introduced in this release
4. Documentation improvements
5. Release branch specific changes (e.g. blocking ci fixes, change version identifiers)

Any other change requires special dispensation from the release managers (currently @malfet, @atalman, @weiwangmeta , @izaitsevfb). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.

Phase 2 (after 12/15/2022):

Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks

Changes will likely require a discussion with the larger release team over VC or Slack.

Cherry-Pick Process

1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).

2. Create (but do not land) a PR against the release branch.

   # Find the hash of the commit you want to cherry pick
   # (for example, abcdef12345)
   git log
   
   git fetch origin release/1.13
   git checkout release/1.13
   git cherry-pick abcdef12345
   
   # Submit a PR based against 'release/1.10' either:
   # via the GitHub UI
   git push my-fork
   
   # via the GitHub CLI
   gh pr create --base release/1.13

3. Make a request below with the following format:

Link to landed master PR (if applicable):
* 

Link to release branch PR:
* 

Criteria Category:
* 

1. Someone from the release team will reply with approved / denied or ask for more information.
2. If approved, someone from the release team will merge your PR once the tests pass. Do not land the release branch PR yourself.

NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.

See HUD 1.13

[roywei]

can we include this security fix as well? #88868

[atalman]

Link to landed master PR (if applicable):

• Update masked.rst #89758

Link to release branch PR:

• Update masked.rst (#89758) #89923

Criteria Category:

• Documentation change

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• Add platform markers for linux only extra_install_requires #88826

Link to release branch PR:

• Add platform markers for linux only extra_install_requires (#88826) #89924

Criteria Category:

• Critical Fix

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• [JIT][Security] Do not blindly eval input string #89189

Link to release branch PR:

• [JIT][Security] Do not blindly eval input string (#89189) #89925

Criteria Category:

• Critical security fix

---

@malfet merged

[weiwangmeta]

Link to landed master PR (if applicable):

• Use the Python frame safely in _pythonCallstack #88993

Link to release branch PR:

• Use the Python frame safely in _pythonCallstack (#88993) #89927

Criteria Category:

• To be updated

Update:

• Closing without merge, going to merge Use the Python frame safely in _pythonCallstack (#88993) #89997 instead

[weiwangmeta]

Link to landed master PR (if applicable):

• Prevent module full_backward_hook from erroring in double backward #88357

Link to release branch PR:

• Prevent module full_backward_hook from erroring in double backward (#… #89928

Criteria Category:

• Critical fix

---

@atalman merged

[weiwangmeta]

Link to landed master PR (if applicable):

• Fix get_default_qat_qconfig for PT 1.13 #88876

Link to release branch PR:

• Fix get_default_qat_qconfig for PT 1.13 (#88876) #89931

Criteria Category:

• To be updated

---

@atalman merged

[weiwangmeta]

Link to landed master PR (if applicable):

• Fix cuda/cpu check on NoneType (Unit test) #88970

Link to release branch PR:

• Fix cuda/cpu check on NoneType (Unit test) (#88970) #89934

Criteria Category:

• Regressions Runtime Error raised by torch.nn.modules.activation.MultiheadAttention when bias=False, batch_first=True #88669

---

@atalman merged

[charlie-wt]

Link to landed master PR (if applicable):

• Use the Python frame safely in _pythonCallstack #88993

Link to release branch PR:

• Use the Python frame safely in _pythonCallstack (#88993) #89997

Criteria category:

• 2: Prevents a crash, which was introduced here, tagged for 1.13

---

@atalman merged

[charlie-wt]

Link to landed master PR (if applicable):

• Mark IPU device as not supports_as_strided #89130

Link to release branch PR:

• Mark IPU device as not supports_as_strided (#89130) #89998

Criteria Category:

• 2: This affects correct behaviour of IPU tensors, in the out-of-tree IPU backend.

---

@atalman merged

[charlie-wt]

Link to landed master PR (if applicable):

• Handle Tensor.__deepcopy__ via clone(), on IPU #89129

Link to release branch PR:

• Handle Tensor.__deepcopy__ via clone(), on IPU (#89129) #89999

Criteria Category:

• 2: This affects correct behaviour of IPU tensors, in the out-of-tree IPU backend.

---

@atalman merged

[izaitsevfb]

Link to landed master PR (if applicable):

• Fix ONNX operator_export_type on the new registry #87735

Link to release branch PR:

• Fix ONNX operator_export_type on the new registry #87735 #90044

Criteria Category:

• Regression

---

@izaitsevfb merged

[izaitsevfb]

Link to landed master PR (if applicable):

• Make TorchElastic timer importable on Windows #88522

Link to release branch PR:

• Make TorchElastic timer importable on Windows (#88522) #90045

Issue fixed:

• torchrun AttributeError caused by file_based_local_timer on Windows #85427

Criteria Category:

• Regression

---

@atalman merged

[weiwangmeta]

Link to landed master PR (if applicable):

• Fix cuda/cpu check on NoneType #88854

Link to release branch PR:

• Fix cuda/cpu check on NoneType (#88854) #90068

Issue fixed:

• Runtime Error raised by torch.nn.modules.activation.MultiheadAttention when bias=False, batch_first=True #88669

Criteria Category:

• Regression

---

@atalman merged

[izaitsevfb]

Link to landed master PR (if applicable):

• Fix ATen Fallback for BUILD_CAFFE2=0 for ONNX-only ops #88504

Link to release branch PR:

• Fix ATen Fallback for BUILD_CAFFE2=0 for ONNX-only ops (#88504) #90104

Criteria Category:

• Regression

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• NA

Link to release branch PR:

• [Release only change] Uninstall sympy while running windows tests #90210

Criteria Category:

• Release only change fixes, failing tests

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• NA

Link to release branch PR:

• [Release only change] Fix rocm5.1.1 docker image #90321

Criteria Category:

• Release only, Critical CI fix (Rocm 5.1.1)

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• Refactor and fix windows smoke tests builder#1218

Link to release branch PR:

• Refactor and fix windows smoke tests (#1218) builder#1222

Criteria Category:

• Critical CI fix - builder repo

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• Add manual cuda deps search logic #90411

Link to release branch PR:

• Add manual cuda deps search logic (#90411) #90426

Criteria Category:

• Critical Fix, amazon linux 2 installation failure

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• [BE] Do not package caffe2 in wheel #87986

Link to release branch PR:

• [BE] Do not package caffe2 in wheel (#87986) #90433

Criteria Category:

• Critical fix for release, limiting produced binary size

---

@atalman merged

[malfet]

Link to landed master PR (if applicable):

• NA

Link to release branch PR:

• [1.13.1] Update XLA pin #90506

Criteria Category:

• Release specific CI fixes (uses the same xla hash for build and test)

---

@malfet: merged

[atalman]

Link to landed master PR (if applicable):

• NA

Link to release branch PR:

• [Release only change] Turn off failing tests in release #90519

Criteria Category:

• Release only change, turn off test that was enabled just before 1.13.1 but disabled for 1.13.0

---

@atalman merged

[roywei]

Hi, request to fix this installation issue for 1.13.1, thanks a lot!
#90673

---

@atalman wrote: Yes, this should be resolved now.

[kevalmorabia97]

Link to landed master PR (if applicable):

• Fix unconvertible_ops as per #89261 #89299

Link to release branch PR:

• Fix unconvertible_ops as per #89261 (#89299) #90684

Criteria Category:

• Bug fix: regression with previous releases

---

@atalman reviewed: According to following comment #89261 (comment) this is not a hi-priority issue. We are 2 days away from the release, at this point we can accept only Critical and high priority fixes to avoid a delay with this release.

@malfet: Test bundled with the PR does not confirm it is a regression from previous release, see #89299 (comment)

@kevalmorabia97: Fixed the test case to verify this is a regression. Do we want to merge this PR now?

@atalman: Please note: merging this fix would require us to delay the release, and repeat all the testing we have done before this release. We only allow to do it for critical hi-priority fixes. According to the comments on the PR this is not hi priority issue.

[atalman]

Please note, we don't accept cherry-picks anymore. The release is scheduled on Dec 15 to go live.

[atalman]

Closing the issue tracker since release is live