Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: pin torch 1.13 for testing #3681

Closed
wants to merge 11 commits into from
Closed

build: pin torch 1.13 for testing #3681

wants to merge 11 commits into from

Conversation

julian-risch
Copy link
Member

@julian-risch julian-risch commented Dec 8, 2022

Related Issues

The pre-installed version of torch in google colab is torch 1.13.0+cu116 since this morning and causes problems.

In the CI with torch 1.13 it seems that there are problems with faiss. Maybe the order of the imports. I will try to import torch before faiss.

It might be that the problem gets fixed with the next torch release thanks to this PR. We could see a 1.13.1 release candidate today and the full release in one week.

Locally on M1 I was able to run tutorial 1 with torch 1.13 installed without issues.

 Attempting uninstall: torch
    Found existing installation: torch 1.13.0+cu116
    Uninstalling torch-1.13.0+cu116:
      Successfully uninstalled torch-1.13.0+cu116
  Attempting uninstall: torchvision
    Found existing installation: torchvision 0.14.0+cu116
    Uninstalling torchvision-0.14.0+cu116:
      Successfully uninstalled torchvision-0.14.0+cu116
Successfully installed Mako-1.2.4 alembic-1.8.1 azure-ai-formrecognizer-3.2.0 azure-common-1.1.28 azure-core-1.26.1 backoff-1.11.1 databricks-cli-0.17.3 docker-5.0.3 docopt-0.6.2 elasticsearch-7.17.7 farm-haystack-1.12.0rc0 gitdb-4.0.10 gitpython-3.1.29 gunicorn-20.1.0 huggingface-hub-0.11.1 isodate-0.6.1 jarowinkler-1.2.3 langdetect-1.0.9 mlflow-2.0.1 mmh3-3.0.0 monotonic-1.6 msrest-0.7.1 num2words-0.5.12 posthog-2.2.0 pyjwt-2.6.0 python-docx-0.8.11 quantulum3-0.7.11 querystring-parser-1.2.4 rank-bm25-0.2.2 rapidfuzz-2.7.0 sentence-transformers-2.2.2 sentencepiece-0.1.97 seqeval-1.2.2 shap-0.41.0 slicer-0.0.7 smmap-5.0.0 tika-1.24 tokenizers-0.12.1 torch-1.12.1 torchvision-0.13.1 transformers-4.21.2 websocket-client-1.4.2
  Running command git clone --filter=blob:none --quiet https://github.com/deepset-ai/haystack.git /tmp/pip-install-lwqbfdr0/farm-haystack_542de4737f8743459d9d84e6751ac943
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
torchtext 0.14.0 requires torch==1.13.0, but you have torch 1.12.1 which is incompatible.
torchaudio 0.13.0+cu116 requires torch==1.13.0, but you have torch 1.12.1 which is incompatible.

With GPU
Tutorials working: 1, 2, 3, 6, 7, 8
Tutorials not working working: none so far
Elasticsearch not starting: 4, 11

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@julian-risch julian-risch requested a review from a team as a code owner December 8, 2022 08:53
@julian-risch julian-risch requested review from ZanSara and mayankjobanputra and removed request for a team December 8, 2022 08:53
@julian-risch
Copy link
Member Author

The testing was successful and we will merge the torch version upgrade in #3727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade torch to 1.13.0
2 participants