Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise torch lower version bound to >=1.13.1 (CVE-2022-45907) #1673

Closed
LGro opened this issue Feb 14, 2023 · 4 comments
Closed

Raise torch lower version bound to >=1.13.1 (CVE-2022-45907) #1673

LGro opened this issue Feb 14, 2023 · 4 comments

Comments

@LGro
Copy link

LGro commented Feb 14, 2023

There is a known security vulnerability (CVE-2022-45907) in torch <= 1.13.0 which is patched since 1.13.1 (pytorch/pytorch/issues/89855). However, the torch lower version bound in botorch's current requirements still seems to be torch>=1.11.

What are your thoughts about raising this lower version bound to torch>=1.13.1 to promote using only dependencies without known security vulnerabilities with the current botorch releases?

@Balandat
Copy link
Contributor

Balandat commented Feb 14, 2023

Hmm 1.13.1 is the most recent release and I'm somewhat hesitant to seize supporting at least the 1.12 series. But we could use a version exclusion of the form torch != 1.13.0 to make sure we disallow that specific version.

@Balandat
Copy link
Contributor

Oh I misread the vulnerability, this is actually present in all versions, not just 1.13.0, my bad.

@saitcakmak
Copy link
Contributor

This seems like a relatively minor security vulnerability. From the original pytorch issue on this:

I believe the vulnerability is, if someone crafts a malicious Python file, and then you compile it TorchScript, it can trigger arbitrary code execution. That being said, I'm not really sure what your threat model is, since you probably already have problems if you're compiling arbitrary malicious Python code with TorchScript?

@LGro
Copy link
Author

LGro commented Feb 16, 2023

I trust your judgement about the trade off between a broader torch compatibility and the security benefits that the fix in 1.13.0 brings, just wanted to make sure it's a conscious one instead of an oversight ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants