Implement convert_to_onnx.py #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
approved these changes
Apr 11, 2023
paolo-viceconte
approved these changes
Apr 12, 2023
| torch==1.13.0 |
There was a problem hiding this comment.
I tried to run both the training and testing scripts with this PyTorch version. They work fine.
Co-authored-by: Paolo Viceconte <paolomariaviceconte@gmail.com>
|
In 9ed8fec I also added the onnx model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to convert the pytorch model into onnx via the new script
scripts/convert_to_onnx.pyI also need to ask for pytorch 1.13.0 to avoid this issue: pytorch/pytorch#51183
By the way, I discovered that Pytorch 1.13.0 has a vulnerability. Indeed in PyTorch before trunk/89695, torch.jit.annotations.parse_type_line can cause arbitrary code execution because eval is used unsafely. The fix for this issue is available in version 1.13.1. There is a release checker in pytorch/pytorch#89855.
So we may think to ask for pytorch
1.13.1