Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump torch due to security vulnerability #11

Merged
merged 1 commit into from Jan 12, 2023
Merged

chore: bump torch due to security vulnerability #11

merged 1 commit into from Jan 12, 2023

Conversation

cragwolfe
Copy link
Contributor

@cragwolfe cragwolfe commented Jan 6, 2023 •
edited

Addresses issue:

In PyTorch before trunk/89695, torch.jit.annotations.parse_type_line can cause arbitrary code execution because eval is used unsafely. The fix for this issue is available in version 1.13.1. There is a release checker in pytorch/pytorch#89855.

@cragwolfe
Copy link
Contributor Author

Somewhat separate issue, but it seems there are too many strict pins in base.in. If a package needs to be pinned to an exact version, there should be a comment above it saying why.

MthwRobinson
MthwRobinson approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cragwolfe cragwolfe merged commit 84b2e7e into main Jan 12, 2023
@cragwolfe cragwolfe deleted the crag/bump-torch branch January 12, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MthwRobinson MthwRobinson MthwRobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cragwolfe @MthwRobinson