otlp: Prometheus to own its own copy of the otlptranslator package #13991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
approved these changes
Apr 26, 2024
|
Yes, I just want to make sure I'm doing it right before merging 👍 |
aknuds1
changed the title
|
@jesusvazquez could you fix the typo in the commit message (otlptrranslator)? It's kind of a charming typo, but still :D |
Relates to #13842 After a lot of productive discussion between the Prometheus and OpenTelemetry community we decided that it made sense for Prometheus to own its own copy of the code in charge for handling OTLP ingestion traffic. This commit is removing the README and update-copy.sh files that had the previous steps to update the code. Also it is updating the licensing of all the files to make sure the OpenTelemetry provenance is explicit and to state the new ownership. Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
jesusvazquez
force-pushed
the
jvp/update-otlptranslator-code-to-be-owned-by-prometheus
branch
from
ad17b79
to
6f396be
Compare
|
Just did 👍 |
dashpole
reviewed
Apr 26, 2024
This commit updates all the files to 95e8f8fdc2a9dc87230406c9a3cf02be4fd68bea in the opentelemetry-collector-contrib repo. Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
jesusvazquez
force-pushed
the
jvp/update-otlptranslator-code-to-be-owned-by-prometheus
branch
from
1af3655
to
8e9818e
Compare
aknuds1
approved these changes
Apr 30, 2024
jesusvazquez
deleted the
jvp/update-otlptranslator-code-to-be-owned-by-prometheus
branch
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #13842
After a lot of productive discussion between the Prometheus and OpenTelemetry community we decided that it made sense for Prometheus to own its own copy of the code in charge for handling OTLP ingestion traffic.
This commit is removing the README and update-copy.sh files that had the previous steps to update the code.
Also it is updating the licensing of all the files to make sure the OpenTelemetry provenance is explicit and to state the new ownership.