Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace maxTimestamp with standard max function #13966

Merged
merged 4 commits into from Apr 30, 2024
Merged

refactor: replace maxTimestamp with standard max function #13966

merged 4 commits into from Apr 30, 2024

Conversation

komisan19
Copy link
Contributor

@komisan19 komisan19 commented Apr 21, 2024 •
edited by aknuds1

Replace the maxTimestamp function with the standard max function.

@komisan19
refactor: add max func to maxTimestamp
5ab24a0 
Signed-off-by: komisan19 <18901496+komisan19@users.noreply.github.com>
@komisan19 komisan19 force-pushed the refactor/add_max_func_to_maxTimestamp branch from fb8af30 to 5ab24a0 Compare April 21, 2024 14:40
@aknuds1 aknuds1 self-assigned this Apr 22, 2024
@komisan19
fix
3d84d4d 
Signed-off-by: komisan19 <18901496+komisan19@users.noreply.github.com>
@komisan19 komisan19 force-pushed the refactor/add_max_func_to_maxTimestamp branch from 96739d4 to 3d84d4d Compare April 22, 2024 10:04
aknuds1
aknuds1 reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the PR be changed into replacing maxTimestamp with max instead? I don't see the point in wrapping max.

@komisan19
fix
b974a99 
Signed-off-by: komisan19 <18901496+komisan19@users.noreply.github.com>
@komisan19 komisan19 force-pushed the refactor/add_max_func_to_maxTimestamp branch from 56bd85e to b974a99 Compare April 30, 2024 01:46
@komisan19
Copy link
Contributor Author

@aknuds1
Thank you for review!
I was replace to maxTimestap -> max

@komisan19 komisan19 requested a review from aknuds1 April 30, 2024 01:59
@aknuds1 aknuds1 changed the title refactor: add max func to maxTimestamp refactor: replace maxTimestamp with standard max function Apr 30, 2024
aknuds1
aknuds1 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I will wait to merge though until we've merged #13991.

@aknuds1
Merge branch 'main' into refactor/add_max_func_to_maxTimestamp
759ca8b 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 merged commit 7f81065 into prometheus:main Apr 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 aknuds1 approved these changes

@jesusvazquez jesusvazquez Awaiting requested review from jesusvazquez jesusvazquez is a code owner

Assignees

@aknuds1 aknuds1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@komisan19 @aknuds1