Sync w/ upstream #620
Merged
Sync w/ upstream #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: komisan19 <18901496+komisan19@users.noreply.github.com>
Signed-off-by: tesla59 <nishant@heim.id>
Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com> Signed-off-by: Nishant Singh <nishant@heim.id>
Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com> Signed-off-by: Nishant Singh <nishant@heim.id>
docs: storage.md: clarify storage.tsdb.retention.time description
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
…13991) After a lot of productive discussion between the Prometheus and OpenTelemetry community we decided that it made sense for Prometheus to own its own copy of the code in charge for handling OTLP ingestion traffic. This commit is removing the README and update-copy.sh files that had the previous steps to update the code. Also it is updating the licensing of all the files to make sure the OpenTelemetry provenance is explicit and to state the new ownership. Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
…Timestamp refactor: replace maxTimestamp with standard max function
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
OTLP: Use PrometheusConverter directly
|
|
pstibrany
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant changes
These changes include a very significant performant boost to the conversion from OTel to Prometheus remote write format, as can be seen from the PR description. The main reason is switching to hash based metrics identifiers instead of string based ones, using the StableHash algorithm from Prometheus itself.