otlp: Remove OTel feature gate registration from copied translation package #13932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
approved these changes
Apr 18, 2024
|
Yes, we're coming back to this after off-site 🙂 |
dashpole
approved these changes
Apr 24, 2024
jesusvazquez
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Thanks Anthony for bringing this up and solving the feature gates issue!!
We just opened up #13991 stating that prometheus will now own this bits of code and as part of the PR we are removing the README steps and the otel contrib references and updating the licensing.
I hope you don't mind but since this PR is already drifting away @aknuds1 and I think it would make sense to rebase this PR once the other PR is merged.
|
@Aneurysm9 This PR is now unblocked, please rebase your PR |
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
jesusvazquez
force-pushed
the
fix/remove_feature_gate
branch
from
9e3a20e
to
6b2f000
Compare
|
@Aneurysm9 thanks for your PR, I took the liberty of rebasing it to get the latest changes from main. |
kushalShukla-web
pushed a commit
to kushalShukla-web/prometheus
that referenced
this pull request
May 13, 2024
…ackage (prometheus#13932) Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com> Signed-off-by: kushagra Shukla <kushalshukla110@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes OTel Collector feature gates registered in copied translation packages. These feature gates are not used in Prometheus and create duplicate registration conflicts if both the OTel and copied translation packages are imported. Due to the state of the individual feature gates and their uses this change has no effect on the behavior of the translation packages.