Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest mimir-prometheus #8012

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Upgrade to latest mimir-prometheus #8012

merged 1 commit into from
Apr 30, 2024

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Apr 30, 2024

What this PR does

Upgrade to latest mimir-prometheus: de14b0ea393d.

Significant Prometheus changes

The main changes are OTLP related, i.e. that Prometheus now has taken ownership of its otlptranslator package (forked it from opentelemetry-collector-contrib), and that the OTel->Prometheus remote write format translation is now optimized through hash based metric identifiers (instead of string based ones). Prometheus benchmarks show huge performance improvements from the latter.

Benchmarks

The OTLPHandler benchmarks don't show any enormous improvements, but it's possible that this is due to having to convert from Prometheus remote write format to Mimir's. It's also possible that our benchmark suite doesn't quite cover all of the improved cases versus the benchmark suite in Prometheus.

Benchmark stats vs main branch
goos: darwin
goarch: arm64
pkg: github.com/grafana/mimir/pkg/distributor
                        │ main-otlphandler-6.txt │     upgrade-otlphandler-6.txt     │
                        │         sec/op         │   sec/op     vs base              │
OTLPHandler/protobuf-12              262.2µ ± 1%   252.8µ ± 0%  -3.60% (p=0.002 n=6)
OTLPHandler/JSON-12                  384.2µ ± 0%   376.2µ ± 0%  -2.09% (p=0.002 n=6)
geomean                              317.4µ        308.4µ       -2.85%

                        │ main-otlphandler-6.txt │     upgrade-otlphandler-6.txt      │
                        │          B/op          │     B/op      vs base              │
OTLPHandler/protobuf-12             393.8Ki ± 0%   370.1Ki ± 0%  -6.03% (p=0.002 n=6)
OTLPHandler/JSON-12                 440.7Ki ± 0%   416.9Ki ± 0%  -5.41% (p=0.002 n=6)
geomean                             416.6Ki        392.8Ki       -5.72%

                        │ main-otlphandler-6.txt │     upgrade-otlphandler-6.txt      │
                        │       allocs/op        │  allocs/op   vs base               │
OTLPHandler/protobuf-12              6.133k ± 0%   5.127k ± 0%  -16.40% (p=0.002 n=6)
OTLPHandler/JSON-12                  9.167k ± 0%   8.160k ± 0%  -10.99% (p=0.002 n=6)
geomean                              7.498k        6.468k       -13.74%

Which issue(s) this PR fixes or relates to

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@aknuds1 aknuds1 force-pushed the arve/upgrade-prometheus branch 3 times, most recently from f7c8d55 to f757d5e Compare April 30, 2024 12:24
@aknuds1 aknuds1 marked this pull request as ready for review April 30, 2024 12:24
@aknuds1 aknuds1 requested review from grafanabot and a team as code owners April 30, 2024 12:24
CHANGELOG.md Show resolved Hide resolved
@aknuds1 aknuds1 enabled auto-merge (squash) April 30, 2024 13:31
@aknuds1 aknuds1 disabled auto-merge April 30, 2024 13:32
@aknuds1 aknuds1 enabled auto-merge (squash) April 30, 2024 13:33
@aknuds1 aknuds1 disabled auto-merge April 30, 2024 13:58
@aknuds1 aknuds1 force-pushed the arve/upgrade-prometheus branch 2 times, most recently from 33f6796 to e514ef2 Compare April 30, 2024 15:37
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 enabled auto-merge (squash) April 30, 2024 15:46
@aknuds1 aknuds1 merged commit 2032768 into main Apr 30, 2024
29 checks passed
@aknuds1 aknuds1 deleted the arve/upgrade-prometheus branch April 30, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants