Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: log of deprecations in 1.x (to be removed in 2.0) #30228

Closed
jorisvandenbossche opened this issue Dec 12, 2019 · 6 comments
Closed

DEPR: log of deprecations in 1.x (to be removed in 2.0) #30228

jorisvandenbossche opened this issue Dec 12, 2019 · 6 comments
Labels
Admin Administrative tasks related to the pandas project Deprecate Functionality to remove in pandas Master Tracker High level tracker for similar issues
Milestone

Comments

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Dec 12, 2019

Similar issue as #6581, but starting a fresh one for keeping a log of the deprecations we do in the 1.x releases.

1.0.0

1.0.1

1.1.0

1.2.0

1.2.1

1.2.5

1.3.0

1.4.0

1.5.0

1.5.1

1.5.2

@jorisvandenbossche jorisvandenbossche added Admin Administrative tasks related to the pandas project Deprecate Functionality to remove in pandas labels Dec 12, 2019
@jorisvandenbossche jorisvandenbossche added this to the 2.0 milestone Dec 12, 2019
@jbrockmendel
Copy link
Member

For this one, let's use the checkboxes instead of cut/pasting to a separate issue when they are removed.

@jorisvandenbossche
Copy link
Member Author

For this one, let's use the checkboxes instead of cut/pasting to a separate issue when they are removed.

Yes, +1, that's also what I wanted to propose

@gfyoung gfyoung pinned this issue Jan 3, 2020
@jreback jreback unpinned this issue Mar 31, 2020
@topper-123 topper-123 added Master Tracker High level tracker for similar issues and removed Master Tracker High level tracker for similar issues labels May 29, 2020
@mroeschke
Copy link
Member

mroeschke commented Sep 29, 2022

Noting some things to look out for to ensure there's a "thorough" removal when enforcing these deprecations (referencing the original PR may not encompass the extent of the feature)

  • Doc changes
    • Remove/modify docstrings
    • Remove/modify API reference (if applicable)
    • Remove/modify references in User Guide
  • Code changes
    • Remove warning.warn call & modify code as needed
    • Remove related warnings.filterwarnings in other parts of the codebase (if any)
    • Adjust type annotations (if related)
  • Test changes
    • Remove tests checking the FutureWarning
    • Modify/add tests (if any) to confirm the future behavior
    • Remove any related filterwarnings (pytest.mark.filterwarnings, pyproject.toml)

@rhshadrach
Copy link
Member

rhshadrach commented Dec 18, 2022

I searched through the pandas code, found a few more deprecations that weren't previously in the list, and added them.

PR authors: @jbrockmendel, @jorisvandenbossche, and myself

@mroeschke
Copy link
Member

All prior deprecations have been enforced so closing

@rhshadrach
Copy link
Member

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Administrative tasks related to the pandas project Deprecate Functionality to remove in pandas Master Tracker High level tracker for similar issues
Projects
None yet
Development

No branches or pull requests

5 participants