Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: List of deprecations to be removed in 3.0 #50578

Open
datapythonista opened this issue Jan 5, 2023 · 20 comments
Open

DEPR: List of deprecations to be removed in 3.0 #50578

datapythonista opened this issue Jan 5, 2023 · 20 comments
Labels
Deprecate Functionality to remove in pandas Master Tracker High level tracker for similar issues
Milestone
3.0

Comments

@datapythonista
Copy link
Member

datapythonista commented Jan 5, 2023 •
edited by rhshadrach

xref #30228

When opening a PR that introduces a deprecation (starts warning), please add it to this list, so we know what needs to be fully deprecated when releasing pandas 3.0.

2.0

2.1

2.2
@datapythonista datapythonista added the Deprecate Functionality to remove in pandas label Jan 5, 2023
This was referenced Jan 5, 2023
Closed
Merged
@Dr-Irv Dr-Irv mentioned this issue Jan 12, 2023
Open
@topper-123
Copy link
Contributor

#50052 should not be om this list, it is part of the pandas 1.x -> 2.0 cleanup process.

@topper-123
Copy link
Contributor

topper-123 commented Jan 15, 2023 •
edited

Likewise #49560.

EDIT: ive removed both of them from the list.

@lithomas1 lithomas1 added this to the 3.0 milestone Feb 22, 2023
@topper-123 topper-123 added the Master Tracker High level tracker for similar issues label Mar 26, 2023
@DeaMariaLeon
Copy link
Member

Could you add this one to the list please?: DEPR: Series.first() and DataFrame.first()
#53419
@datapythonista

@topper-123
Copy link
Contributor

I've added it, thanks @DeaMariaLeon.

More generally, I can see several deprecatons in the pulse that have not been added, e.g. #52986 & #52981. To my knowledge all deprecations should be added to the list, or has that changed?

@topper-123
Copy link
Contributor

@pandas-dev/pandas-core, looks like we need to be more mindful of adding deprecations to this list. Or is there an alternative method of knowing which deprecations have been done?

@mroeschke
Copy link
Member

There was supposed to be a job that @phofl created that would update the OP https://github.com/pandas-dev/pandas/blob/main/.github/workflows/deprecation-tracking-bot.yml

Has it not been working recently?

@lithomas1
Copy link
Member

I don't think it ever worked except on his repo for some reason.
Looks like there was a permissions issue somewhere.

Here's the log of a recent run
https://github.com/pandas-dev/pandas/actions/runs/5195752658/jobs/9368776352

@lithomas1
Copy link
Member

lithomas1 commented Jun 7, 2023 •
edited

Ok, here's my best guess to what's going wrong.

So Github typically restricts the types of perms a workflow can get if it comes from a fork (you get downgraded to read access).
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#:~:text=permissions%3A%20%7B%7D-,You%20can%20use%20the%20permissions%20key%20to%20add%20and%20remove%20read,more%20information%2C%20see%20%22Managing%20GitHub%20Actions%20settings%20for%20a%20repository.%22,-Example%3A%20Assigning%20permissions

When Patrick tested his code on his fork, he opened a PR from a branch within the fork, so the PR was able to get write perms since it came from the same repo. However, when we PR to the main pandas repo, we do it from our forks, not from branches in the main repo, triggering the permissions downgrade.

I think the solution is to run the workflow with a push trigger, not a pull_request trigger, since only pull_request triggers the permission downgrade.

Probably need https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28#list-pull-requests-associated-with-a-commit to map the commit back to the original PR.

I'll try to have something up soonish.

@lithomas1 lithomas1 mentioned this issue Jun 10, 2023
Merged
5 tasks
@lithomas1
Copy link
Member

It works 🎉 !
(Bot added #53493)

One thing to keep in mind though is that adding the "Deprecate" label is necessary to trigger the bot.
(It doesn't trigger when the commit message/PR title has "DEPR" in it).

I've added #53607 manually, hopefully there's not anything else missing.

@phofl
Copy link
Member

phofl commented Jun 13, 2023

Thx for fixing the bot!

@pllim pllim mentioned this issue Jul 7, 2023
Open
@jbrockmendel
Copy link
Member

@natmokval can you check off the boxes above that you have already handled. i think you've done a bunch of them

@natmokval natmokval assigned natmokval and unassigned natmokval Mar 29, 2024
@natmokval
Copy link
Contributor

natmokval commented Mar 29, 2024 •
edited

@natmokval can you check off the boxes above that you have already handled. i think you've done a bunch of them

thanks @jbrockmendel. I tried to check the boxes off, but it didn't work. Maybe I don't have permissions to do it.

@rhshadrach
Copy link
Member

@natmokval - that's surprising, I would think triage permissions would allow you to edit any comment. Are you able to edit this comment?

In the meantime, you could list the PRs to be checked off in a comment here and someone else can update the OP.

@jbrockmendel
Copy link
Member

darn, thanks for taking a look.

@natmokval
Copy link
Contributor

@natmokval - that's surprising, I would think triage permissions would allow you to edit any comment. Are you able to edit this comment?

no, I can't edit this comment. I am allowed to edit only my comments.

In the meantime, you could list the PRs to be checked off in a comment here and someone else can update the OP.

thanks, @rhshadrach. Here the list of PR’s to be checked off:

I noticed a couple of missing PRs, which are need to be checked off too:

the follow PR is also not on the list:

but I am not finished with the removal yet.

@rhshadrach
Copy link
Member

rhshadrach commented Mar 31, 2024 •
edited

Thanks @natmokval - I've checked off all PRs.

I noticed a couple of missing PRs, which are need to be checked off too:

The 2nd I found in the OP list, however I did not find the first. Should it be added?

@natmokval
Copy link
Contributor

natmokval commented Apr 1, 2024 •
edited

Thanks @natmokval - I've checked off all PRs.

thanks @rhshadrach.

I noticed a couple of missing PRs, which are need to be checked off too:

The 2nd I found in the OP list, however I did not find the first. Should it be added?

yes, I think we should add the first PR in the OP list in 2.0 section. I enforced this deprecation in #58029.

@rhshadrach
Copy link
Member

Thanks @natmokval - done.

@mroeschke mroeschke mentioned this issue Apr 12, 2024
Open
@Aloqeely
Copy link
Contributor

@rhshadrach there are a few more that need to be checked off (correct me if I'm wrong):

enforced by #57425

by #58314 and #58060 respectively

by #57971

also by #57971

by #58053

by #57425

I can't find where, but I think this has been enforced

by #57999

by #58125

by #58059

Should be removed from the list, was reverted in #56481

by #57966

@rhshadrach
Copy link
Member

Thanks @Aloqeely! Updated the OP.

I also removed #52477 from the list. That needs to be made a FutureWarning before we can enforce the deprecation.

@jorisvandenbossche jorisvandenbossche mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Master Tracker High level tracker for similar issues
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
10 participants
@jbrockmendel @datapythonista @mroeschke @DeaMariaLeon @topper-123 @rhshadrach @lithomas1 @Aloqeely @phofl @natmokval