DEPR: positional arguments in favor of keyword arguments #48735
Conversation
ambujpawar
changed the title
mroeschke
added
Deprecate
|
This is currently just changing, not a deprecation. |
doc/source/whatsnew/v1.6.0.rst
Outdated
| @@ -215,6 +214,7 @@ Indexing | |||
| - Bug in :meth:`DataFrame.reindex` filling with wrong values when indexing columns and index for ``uint`` dtypes (:issue:`48184`) | |||
| - Bug in :meth:`DataFrame.reindex` casting dtype to ``object`` when :class:`DataFrame` has single extension array column when re-indexing ``columns`` and ``index`` (:issue:`48190`) | |||
| - Bug in :func:`~DataFrame.describe` when formatting percentiles in the resulting index showed more decimals than needed (:issue:`46362`) | |||
| - :meth:`DataFrameGroupBy.fillna` and :meth:`SeriesGroupBy.fillna` now allow only keyword arguments to be passed except value(:issue:`48395`) | |||
There was a problem hiding this comment.
space after value, and please use value
Also please move to deprecations
There was a problem hiding this comment.
I received contradicting review about moving/not moving to deprecations in the previous comments.
I am kinda confused now regarding which one should I actually do?
There was a problem hiding this comment.
We have a section Other Deprecations where we announce all deprecations before changing behavior in a later release
There was a problem hiding this comment.
Hi, I could not find a section with the name Other Deprecations so moving it to deprecations for now.
|
Just noting logistically I would prefer removing all prior deprecations before adding new ones for 2.0 |
Agreed. Some of the 2.0 deprecations are missing from #30228, so we're gonna end up just grepping for FutureWarning. Adding new ones will cause trouble. |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Needs a rebase, we will start merging deprecations |
| @@ -1075,8 +1075,8 @@ Metadata | |||
|
|
|||
| Other | |||
| ^^^^^ | |||
| - Add future warnings in :meth:`DataFrameGroupBy.fillna` and :meth:`SeriesGroupBy.fillna` allowing only keyword arguments to be passed except ``value`` (:issue:`48395`) | |||
There was a problem hiding this comment.
move to section starting on L564 and reword like the others, so maybe "Deprecated...." instead of mentioning FutureWarning.
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.