Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Enforce 2.0 deprecations #50579

Closed
datapythonista opened this issue Jan 5, 2023 · 7 comments
Closed

DEPR: Enforce 2.0 deprecations #50579

datapythonista opened this issue Jan 5, 2023 · 7 comments
Labels
Deprecate Functionality to remove in pandas
Milestone

Comments

@datapythonista
Copy link
Member

datapythonista commented Jan 5, 2023

xref #30228

List of deprecations pending enforcement before releasing pandas 2.0.

Topic Deprecation PR Enforcement PR Assignee
datetimelike.astype(...) #38544 #45574 #49715 @jbrockmendel
Int64Index, UInt64Index & Float64Index #42717 #43028 #49560 @topper-123
DataFrame.to_latex using Styler #47970 @attack68

Those are from unchecked items in #30228 and #50196 (comment). We should probably run a grep to see what else is pending before we start merging PRs that introduce new deprecations (see #50578).

@datapythonista datapythonista added the Deprecate Functionality to remove in pandas label Jan 5, 2023
@datapythonista datapythonista added this to the 2.0 milestone Jan 5, 2023
@jbrockmendel
Copy link
Member

Is this redundant with #30228?

@mroeschke
Copy link
Member

Yeah it appears these are essentially the "last" depercations that need to be enforced in #30228

@rhshadrach
Copy link
Member

#35967 can be removed since it was never merged, yea?

@datapythonista
Copy link
Member Author

Is this redundant with #30228?

Yes, I thought it'd make it easier to track things. But on a second thought, I think it's probably better to simply have the list of blockers in #46776, whether they're a deprecation or not. So, closing here in favor of the RLS 2.0 issue. Sorry for the noise.

@topper-123
Copy link
Contributor

What is the status of #35967 wrt. changing the default for the observed in groupby? The parameter default was never deprecated, so that means it will not change for 2.0?

This issue is something that relatively often bites people I think, so would be good to change, either as a deprecation or a 2.0 change.

@topper-123
Copy link
Contributor

To add: #35967 is the issue listed in #30228, #43999 is a the same issue, but it's open, so may be the one intended for discussion about this.

@rhshadrach
Copy link
Member

This issue is something that relatively often bites people I think, so would be good to change, either as a deprecation or a 2.0 change.

I'm planning to push for deprecating in 2.x, but would be -1 on changing in 2.0 itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

No branches or pull requests

5 participants