DEPR: Clean up list of deprecations from prior versions

[jsexauer]

Log for previous deprecations, once they are actually removed, move the issue to #13777

We try to keep these for three major versions as actual deprecations. e.g. deprecate in 0.17, 0.18 & 0.19 get the warning, removed in 0.20.

0.24.0

• DEPR: __array__ for tz-aware Series/Index #24596 __array__ for tzaware Series/Index (0.24.0)

[TomAugspurger]

Just FYI, cols is used in to_csv and to_excel as well.

[jreback]

@TomAugspurger good point!

@jsexauer would you do another PR to deprecate cols in to_csv / to_excel (e.g. do what you did in pivot, still accept it, but provide the warning, and substitue columns)

[jsexauer]

Sure no problem.

[jorisvandenbossche]

@jreback I was thinking, now that we are alse deprecating this in to_csv and to_excel, shouldn't we keep this deprecation cycle longer than one release? Because I don't know if the majority of the users update their version every release.

[jtratner]

I agree with @jorisvandenbossche - giving an additional release cycle as buffer would be prudent.

[jreback]

certainly
just keeping open issues as reminders
I just removed the old syntax in in sort I think from like < 0.8!

though maybe will change them to say 0.16 so are at the correct point

[jbrockmendel]

@mroeschke heads up this and 13777 have been behaving poorly w/r/t getting multiple edits in a short period of time. in this case, I think it silently reverted the rolling.apply edit you made

[mroeschke]

Thanks for the headsup @jbrockmendel. Let's see if 2nd's time a charm.

[jbrockmendel]

@TomAugspurger do you have comparative advantage in #23767?

@mroeschke IIRC #22644 was yours, want to finish it off?

@WillAyd didn't you already take care of #18731? if so pls update the checkbox lists

@pandas-dev/pandas-core A few of these that are ambiguous and may need discussion/clarification:

• DEPR: deprecate .add_prefix and .add_suffix #18347 .add_suffix/.add_prefix - the discussion there makes it look like this may not be deprecated after all. Can we confirm the status on this?
• DEPR: Series.compress #21930 Series.compress - removing this breaks np.compress(series). Do we care?
• DEPR: Series.item and Index.item #27112 Series.item & Index.item - there was some recent discussion of un-deprecating item. Where did we land on that?

[jreback]

• +1 on re-enabling .item()
• +0 on deprecating .add_suffix/.add_prefix, IIRC don't believe was actually deprecated
• ok with removing .compress() its not very useful anyhow even in numpy, esp for 1-D where its just indexing.

[jorisvandenbossche]

add_prefix/add_suffix were never deprecated, so there is no discussion about removing them. Someone can open a new issue (or find an existing one) to further discuss deprecating it, but since it is here about removal of actually deprecated things, removed this from the list above.

I think I am fine with np.compress() breaking.

Let's have the discussion about item in #29250 (I am in favor of at least keeping part of it)

[jbrockmendel]

@jorisvandenbossche there are a couple of these I tried and couldn't figure out. Can I get you to take a look or suggest someone I should bug? First is the how fill_method in resample (needs GH ref). Second is the one for #26403.

[jschendel]

Second is the one for #26403.

Just opened a PR for that one, see #29955

[jorisvandenbossche]

First is the how fill_method in resample (needs GH ref)

That deprecation was introduced in #11841. This might be left-overs that were not removed in #20782

[jbrockmendel]

@mroeschke any others you want to call dibs on before i go to town?

[mroeschke]

@jbrockmendel I'll probably be slow on deprecations this week. Go for it.

[jorisvandenbossche]

I moved the deprecations we are doing in 1.0 to a new issue: #30228 (so a similar issue as this to keep a log of deprecations, but starting a fresh one for 1.x)

[TomAugspurger]

All the listed deprecations have been cleaned up. Thanks all!