Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: Remove deprecated ExcelWriter methods #50093

Merged
merged 9 commits into from Dec 13, 2022
Merged

DEPR: Remove deprecated ExcelWriter methods #50093

merged 9 commits into from Dec 13, 2022

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@rhshadrach rhshadrach added IO Excel read_excel, to_excel Deprecate Functionality to remove in pandas labels Dec 6, 2022
@rhshadrach rhshadrach added this to the 2.0 milestone Dec 6, 2022
@rhshadrach rhshadrach changed the title Enforce excel depr DEPR: Remove deprecated ExcelWriter methods Dec 6, 2022
@jbrockmendel
Copy link
Member

io.excel.WriteExcel.time_write_excel asv failed

jbrockmendel
jbrockmendel approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroeschke mroeschke merged commit 1f836f1 into pandas-dev:main Dec 13, 2022
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the enforce_excel_depr branch December 13, 2022 03:10
@jbrockmendel
Copy link
Member

does this handle the #48780 checkbox in #30228?

@mroeschke
Copy link
Member

Looks like it from the added whatsnew note. Checked off the box

@rhshadrach rhshadrach mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas IO Excel read_excel, to_excel
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhshadrach @jbrockmendel @mroeschke @phofl