Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump highlight.js from 10.7.3 to 11.3.1 #1901

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 19, 2021

Bumps highlight.js from 10.7.3 to 11.3.1.

Release notes

Sourced from highlight.js's releases.

11.3.1

Version 11.3.1

Same as 11.3.0 except for the fix to generating optional CDN grammar modules.

Build:

  • (fix) Grammar CDN modules not generated correctly. (#3363) [Josh Goebel][]
  • add HighlightJS named export (#3295) [Josh Goebel][]
  • add .default named export to CJS builds (#3333) [Josh Goebel][]

Parser:

  • add first rough performance testing script (#3280) [Austin Schick][]
  • add throwUnescapedHTML to warn against potential HTML injection [Josh Goebel][]
  • expose regex helper functions via hljs injection [Josh Goebel][]
    • concat
    • lookahead
    • either
    • optional
    • anyNumberOfTimes

Grammars:

  • fix(ts) some complex types would classify as JSX (#3278) [Josh Goebel][]
  • fix(js/ts) less false positives for class X extends Y (#3278) [Josh Goebel][]
  • enh(css): add properties from several W3C (Candidate) Recommendations (#3308)
  • fix(js/ts) Float32Array highlighted incorrectly (#3353) [Josh Goebel][]
  • fix(css) single-colon psuedo-elements no longer break highlighting (#3240) [Josh Goebel][]
  • fix(scss) single-colon psuedo-elements no longer break highlighting (#3240) [Josh Goebel][]
  • enh(fsharp) rewrite most of the grammar, with many improvements [Melvyn Laïly][]
  • enh(go) better type highlighting, add error type [Josh Goebel][]
  • fix(js/ts) regex inside SUBST is no longer highlighted [Josh Goebel][]
  • fix(python) added support for unicode identifiers (#3280) [Austin Schick][]
  • enh(css/less/stylus/scss) improve consistency of function dispatch (#3301) [Josh Goebel][]
  • enh(css/less/stylus/scss) detect block comments more fully (#3301) [Josh Goebel][]
  • fix(cpp) switch is a keyword (#3312) [Josh Goebel][]
  • fix(cpp) fix xor_eq keyword highlighting. [Denis Kovalchuk][]
  • enh(c,cpp) highlight type modifiers as type (#3316) [Josh Goebel][]
  • enh(css/less/stylus/scss) add support for CSS Grid properties [monochromer][]
  • enh(java) add support for Java Text Block (#3322) [Teletha][]
  • enh(scala) add missing do and then keyword (#3323) [Nicolas Stucki][]
  • enh(scala) add missing enum, export and given keywords (#3328) [Nicolas Stucki][]
  • enh(scala) remove symbol syntax and fix quoted code syntax (#3324) [Nicolas Stucki][]
  • enh(scala) add Scala 3 extension soft keyword (#3326) [Nicolas Stucki][]
  • enh(scala) add Scala 3 end soft keyword (#3327) [Nicolas Stucki][]
  • enh(scala) add inline soft keyword (#3329) [Nicolas Stucki][]
  • enh(scala) add using soft keyword (#3330) [Nicolas Stucki][]
  • enh(fsharp) added f# alias (#3337) [Bahnschrift][]
  • enh(bash) added gnu core utilities (#3342) [katzeprior][]

... (truncated)

Changelog

Sourced from highlight.js's changelog.

Version 11.3.1

Build:

Version 11.3.0

Build:

Parser:

  • add first rough performance testing script (#3280) [Austin Schick][]
  • add throwUnescapedHTML to warn against potential HTML injection Josh Goebel
  • expose regex helper functions via hljs injection Josh Goebel
    • concat
    • lookahead
    • either
    • optional
    • anyNumberOfTimes

Grammars:

  • fix(ts) some complex types would classify as JSX (#3278) Josh Goebel
  • fix(js/ts) less false positives for class X extends Y (#3278) Josh Goebel
  • enh(css): add properties from several W3C (Candidate) Recommendations (#3308)
  • fix(js/ts) Float32Array highlighted incorrectly (#3353) Josh Goebel
  • fix(css) single-colon psuedo-elements no longer break highlighting (#3240) Josh Goebel
  • fix(scss) single-colon psuedo-elements no longer break highlighting (#3240) Josh Goebel
  • enh(fsharp) rewrite most of the grammar, with many improvements [Melvyn Laïly][]
  • enh(go) better type highlighting, add error type Josh Goebel
  • fix(js/ts) regex inside SUBST is no longer highlighted Josh Goebel
  • fix(python) added support for unicode identifiers (#3280) [Austin Schick][]
  • enh(css/less/stylus/scss) improve consistency of function dispatch (#3301) Josh Goebel
  • enh(css/less/stylus/scss) detect block comments more fully (#3301) Josh Goebel
  • fix(cpp) switch is a keyword (#3312) Josh Goebel
  • fix(cpp) fix xor_eq keyword highlighting. [Denis Kovalchuk][]
  • enh(c,cpp) highlight type modifiers as type (#3316) Josh Goebel
  • enh(css/less/stylus/scss) add support for CSS Grid properties [monochromer][]
  • enh(java) add support for Java Text Block (#3322) [Teletha][]
  • enh(scala) add missing do and then keyword (#3323) [Nicolas Stucki][]
  • enh(scala) add missing enum, export and given keywords (#3328) [Nicolas Stucki][]
  • enh(scala) remove symbol syntax and fix quoted code syntax (#3324) [Nicolas Stucki][]
  • enh(scala) add Scala 3 extension soft keyword (#3326) [Nicolas Stucki][]

... (truncated)

Commits
  • 2a972d8 (chore) remove extra linebreak
  • 175b856 (release) bump 11.3.1
  • 3d1836f (chore) add tiny header to HLJS grammar modules
  • 76efccf (fix/chore) safer wrapper for IIFE grammar plugins
  • 0ce3979 11.3.0
  • fbf9534 fix(js/ts) fix detecting types as JSX (#3278)
  • 0f70132 (chore) export named HighlightJS export in Node packages (#3307)
  • 7315fb1 enh(css) add support for hex color alpha channel (#3360) (#3362)
  • 7cb4e3d enh(nsis) adds NSIS v3.08 commands, some small improvements (#3351)
  • fc35be5 fix(css/scss/less/stylus) support single colon when using pseudo element sele...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added 3. to review dependencies Pull requests that update a dependency file labels Oct 19, 2021
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/highlight.js-11.3.1 branch from 7aad5b5 to 8f751b2 Compare October 23, 2021 02:07
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/highlight.js-11.3.1 branch from 8f751b2 to 3980c33 Compare October 25, 2021 09:53
@azul
Copy link
Contributor

azul commented Oct 27, 2021

I had a brief look at this and the failure seems to be caused by the update of highlight js.
I did not see any relevant changes in their package.json since 10.x - so not sure what caused this.

@juliushaertl
Copy link
Member

Looks like highlightjs/highlight.js#3223 (comment) due to the fact that we also do that kind of dynamic import:

https://github.com/nextcloud/text/blob/master/src/EditorFactory.js#L51

@azul
Copy link
Contributor

azul commented Oct 27, 2021

So looks like it's a bug in webpack with a few options to work around.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 27, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/highlight.js-11.3.1 branch October 27, 2021 21:54
@azul azul restored the dependabot/npm_and_yarn/highlight.js-11.3.1 branch October 29, 2021 12:04
@azul
Copy link
Contributor

azul commented Oct 29, 2021

webpack/webpack#13865 is breaking this - but the workaround in #1915 did not work. So I'll reopen this so we do not lose track of it.

@azul azul reopened this Oct 29, 2021
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/highlight.js-11.3.1 branch from 3980c33 to e65090e Compare October 29, 2021 12:05
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/highlight.js-11.3.1 branch from e65090e to 185caa5 Compare October 30, 2021 05:18
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/highlight.js-11.3.1 branch from 185caa5 to 7b38509 Compare November 5, 2021 16:01
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/highlight.js-11.3.1 branch from 7b38509 to dbde392 Compare November 5, 2021 16:56
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/highlight.js-11.3.1 branch from dbde392 to 5a4c8cd Compare November 5, 2021 17:14
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/highlight.js-11.3.1 branch from 5a4c8cd to 761c9c9 Compare November 5, 2021 18:59
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 10.7.3 to 11.3.1.
- [Release notes](https://github.com/highlightjs/highlight.js/releases)
- [Changelog](https://github.com/highlightjs/highlight.js/blob/main/CHANGES.md)
- [Commits](highlightjs/highlight.js@10.7.3...11.3.1)

---
updated-dependencies:
- dependency-name: highlight.js
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/highlight.js-11.3.1 branch from 761c9c9 to 829a75e Compare November 11, 2021 09:37
@azul
Copy link
Contributor

azul commented Nov 11, 2021

I found a workaround for the webpack issue in #1942. However there's another issue with dependencies as the Highlight plugin of tiptap-extensions seems to be bound to lowlight 1.x which is not compatible with highlight.js 11.x.

So closing this and giving up until we migrate to tiptap2 or so.

@azul azul closed this Nov 11, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/highlight.js-11.3.1 branch November 11, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants