Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F# as alias for F# #3337

Merged
merged 3 commits into from Sep 19, 2021
Merged

Add F# as alias for F# #3337

merged 3 commits into from Sep 19, 2021

Conversation

Bahnschrift
Copy link
Contributor

Changes

Checklist

  • Added markup tests, or they don't apply here because it's just the addition of an alias
  • Updated the changelog at CHANGES.md

Added F# as alias for F#. More consistent with C#.
CHANGES.md Outdated
@@ -22,6 +22,7 @@ Grammars:
- enh(scala) add Scala 3 `end` soft keyword (#3327) [Nicolas Stucki][]
- enh(scala) add `inline` soft keyword (#3329) [Nicolas Stucki][]
- enh(scala) add `using` soft keyword (#3330) [Nicolas Stucki][]
- enh(fsharp) added `f#` alias [Bahnschrift][]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a foot link also, lines ~30.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Should be all fixed now.

Copy link
Member

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just need the link.

@joshgoebel joshgoebel merged commit f8b4434 into highlightjs:main Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants