Bump highlight.js from 10.7.3 to 11.3.1 fixing build #1915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azul
commented
Oct 27, 2021
Comment on lines
-51
to
+52
| const lang = await import(/* webpackChunkName: "highlight/[request]" */'highlight.js/lib/languages/' + languages[i]) | ||
| const langModule = 'highlight.js/lib/languages/' + languages[i] | ||
| const lang = await import(/* webpackChunkName: "highlight/[request]" */langModule) |
There was a problem hiding this comment.
This seems to do the trick.
I have no idea why though - so i'm not sure if we want to include this.
There was a problem hiding this comment.
Also this seems to fix the build but the syntax highlighting files are no longer included.
Found another bug when testing this #1916 but even with that it seems there is no request for the dynamic chunk name then.
azul
force-pushed
the
upgrade/highlight.js-11.3.1
branch
from
2c01726
to
e9c34c6
Compare
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 10.7.3 to 11.3.1. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/main/CHANGES.md) - [Commits](highlightjs/highlight.js@10.7.3...11.3.1) --- updated-dependencies: - dependency-name: highlight.js dependency-type: direct:production update-type: version-update:semver-major ... Work around a bug in webpack with dynamic imports: webpack/webpack#13865 Signed-off-by: dependabot[bot] <support@github.com>
azul
force-pushed
the
upgrade/highlight.js-11.3.1
branch
from
e9c34c6
to
11b3004
Compare
|
Okay... this just broke the dynamic import but it's definitely not the way to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumps highlight.js from 10.7.3 to 11.3.1.
updated-dependencies:
dependency-type: direct:production
update-type: version-update:semver-major
...
Work around a bug in webpack with dynamic imports:
webpack/webpack#13865
Signed-off-by: dependabot[bot] support@github.com