Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js/ts) Float32Array higlighted incorrectly #3353

Merged
merged 5 commits into from Oct 12, 2021
Merged

fix(js/ts) Float32Array higlighted incorrectly #3353

merged 5 commits into from Oct 12, 2021

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Oct 7, 2021 •
edited

Changes

Resolves #3252.

  • Improves the class name detection regex to handle more cases like Float32Array or CSSParser

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@joshgoebel joshgoebel requested a review from allejo October 7, 2021 15:28
allejo
allejo approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sane enough to me. The only notable exception to this would be the JSON object that is treated as a constant (which, isn't too far from the truth I guess).

image

src/languages/javascript.js Show resolved Hide resolved
@joshgoebel
Copy link
Member Author

The only notable exception to this would be the JSON object

I may go ahead and hard-code that as an exception to the constant rule. :-) I think that makes sense for a core library class.

@joshgoebel joshgoebel merged commit 1c79370 into highlightjs:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Javascript) Float32Array broken after 11.0.1
2 participants
@joshgoebel @allejo