Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(java) Add support for text block #3322

Merged
merged 6 commits into from Sep 4, 2021
Merged

enh(java) Add support for text block #3322

merged 6 commits into from Sep 4, 2021

Conversation

teletha
Copy link
Contributor

@teletha teletha commented Sep 3, 2021

https://docs.oracle.com/javase/specs/jls/se15/html/jls-3.html#jls-TextBlock

Changes

Adds highlight for Java(15~) Text Block.

@joshgoebel
Copy link
Member

Please also add changelog and a markup test.

@joshgoebel
Copy link
Member

Please see failling tests, the markup results must be HTML escaped. This might help:

https://github.com/highlightjs/highlight.js/blob/main/test/markup/index.js#L32

@teletha teletha closed this Sep 4, 2021
@teletha teletha reopened this Sep 4, 2021
@joshgoebel
Copy link
Member

@teletha Thanks so much for contribution!

@joshgoebel joshgoebel merged commit 3cc0800 into highlightjs:main Sep 4, 2021
@teletha teletha deleted the patch-1 branch September 4, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants