Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 0.66.0 to 0.67.1 #394

Closed
wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps rubocop from 0.66.0 to 0.67.1.

Release notes

Sourced from rubocop's releases.

RuboCop 0.67.1

Changes

  • #6881: Set default PreferredName to e for Naming/RescuedExceptionsVariableName. (@​koic)

RuboCop 0.67

New features

  • #5184: Add new multiline element line break cops. (@​maxh)
  • Add new cop Rails/ActiveRecordOverride that checks for overriding Active Record methods instead of using callbacks. (@​elebow)
  • Add new cop Rails/RedundantAllowNil that checks for cases when allow_blank makes allow_nil unnecessary in model validations. (@​elebow)
  • Add new Naming/RescuedExceptionsVariableName cop. (@​AdrienSldy)

Bug fixes

  • #6761: Make Naming/UncommunicativeMethodParamName account for param names prefixed with underscores. (@​thomthom)
  • #6855: Fix an exception in Rails/RedundantReceiverInWithOptions when the body is empty. (@​ericsullivan)
  • #6856: Fix auto-correction for Style/BlockComments when the file is missing a trailing blank line. (@​ericsullivan)
  • #6858: Fix an incorrect auto-correct for Lint/ToJSON when there are no to_json arguments. (@​koic)
  • #6865: Fix deactivated StyleGuideBaseURL for Layout/ClassStructure. (@​aeroastro)
  • #6868: Fix Rails/LinkToBlank auto-correct bug when using symbol for target. (@​r7kamura)
  • #6869: Fix false positive for Rails/LinkToBlank when rel is a symbol value. (@​r7kamura)
  • Add IncludedMacros param to default rubocop config for Style/MethodCallWithArgsParentheses. (@​maxh)
  • #6785: Do not register an offense for Rails/Present or Rails/Blank in an unless else context when Style/UnlessElse is enabled. (@​rrosenblum)

Changes

  • #6854: Mark Rails/LexicallyScopedActionFilter as unsafe and document risks. (@​urbanautomaton)
  • #5977: Warn for Performance Cops. (@​koic)
  • #6637: Move LstripRstrip from Performance to Style department and rename it to Strip. ([@​anuja-joshi][])
  • #6875: Mention block form of Struct.new in Style/StructInheritance. ([@​XrXr][])
  • #6871: Move Performance/RedundantSortBy, Performance/UnneededSort and Performance/Sample to the Style department. ([@​bbatsov][])

[@​anuja-joshi]: https://github.com/anuja-joshi
[@​XrXr]: https://github.com/XrXr
[@​bbatsov]: https://github.com/bbatsov

Changelog

Sourced from rubocop's changelog.

0.67.1 (2019-04-04)

Changes

  • #6881: Set default PreferredName to e for Naming/RescuedExceptionsVariableName. (@​koic)

0.67.0 (2019-04-04)

New features

  • #5184: Add new multiline element line break cops. (@​maxh)
  • Add new cop Rails/ActiveRecordOverride that checks for overriding Active Record methods instead of using callbacks. (@​elebow)
  • Add new cop Rails/RedundantAllowNil that checks for cases when allow_blank makes allow_nil unnecessary in model validations. (@​elebow)
  • Add new Naming/RescuedExceptionsVariableName cop. (@​AdrienSldy)

Bug fixes

  • #6761: Make Naming/UncommunicativeMethodParamName account for param names prefixed with underscores. (@​thomthom)
  • #6855: Fix an exception in Rails/RedundantReceiverInWithOptions when the body is empty. (@​ericsullivan)
  • #6856: Fix auto-correction for Style/BlockComments when the file is missing a trailing blank line. (@​ericsullivan)
  • #6858: Fix an incorrect auto-correct for Lint/ToJSON when there are no to_json arguments. (@​koic)
  • #6865: Fix deactivated StyleGuideBaseURL for Layout/ClassStructure. (@​aeroastro)
  • #6868: Fix Rails/LinkToBlank auto-correct bug when using symbol for target. (@​r7kamura)
  • #6869: Fix false positive for Rails/LinkToBlank when rel is a symbol value. (@​r7kamura)
  • Add IncludedMacros param to default rubocop config for Style/MethodCallWithArgsParentheses. (@​maxh)
  • #6785: Do not register an offense for Rails/Present or Rails/Blank in an unless else context when Style/UnlessElse is enabled. (@​rrosenblum)

Changes

  • #6854: Mark Rails/LexicallyScopedActionFilter as unsafe and document risks. (@​urbanautomaton)
  • #5977: Warn for Performance Cops. (@​koic)
  • #6637: Move LstripRstrip from Performance to Style department and rename it to Strip. ([@​anuja-joshi][])
  • #6875: Mention block form of Struct.new in Style/StructInheritance. ([@​XrXr][])
  • #6871: Move Performance/RedundantSortBy, Performance/UnneededSort and Performance/Sample to the Style department. ([@​bbatsov][])
Commits
  • 01918a1 Cut 0.67.1
  • d0677d7 Set default PreferredName to e for Naming/RescuedExceptionsVariableName
  • 1d0e480 Cut 0.67
  • 2513212 Fix the manual
  • f0959e8 Add new Naming/RescuedExceptionsVariableName cop
  • b05bb15 [Fix #6785] Make Rails/Blank and Rails/Present aware of Style/UnlessElse
  • 93b1fc1 Update a bit of cop metadata
  • ad5c5f9 [Fix #5184] Add new multiline element line break cops (#6824)
  • 2a4dfca Add STDERR.puts check to Style/StderrPuts cop
  • 32ed7d1 [Fix #6871] Move several performance cops to the style department
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.66.0 to 0.67.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.66.0...v0.67.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Apr 5, 2019
@rossjones
Copy link
Contributor

rossjones commented Apr 5, 2019

This PR causes problems.

An error occurred while Rails/RedundantAllowNil cop was inspecting /home/circleci/repo/app/models/pom_detail.rb:6:2

This PR is broken, the 0.67 and 0.67.1 releases are borked. See rubocop/rubocop#6882

In 0.67 the error looked like a utf8 error. In 0.67.1 it's a nil deref.

Let's wait for the next version.

@rossjones rossjones closed this Apr 5, 2019
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@rossjones rossjones deleted the dependabot/bundler/rubocop-0.67.1 branch April 5, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants