Fix false positive for Rails/LinkToBlank when rel is a symbol value
#6869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r7kamura
force-pushed
the
feature/rails-link-to-blank-symbol-rel
branch
from
1a997e7
to
77282a0
Compare
koic
reviewed
Apr 1, 2019
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ | |||
| * [#6856](https://github.com/rubocop-hq/rubocop/pull/6856): Fix auto-correction for `Style/BlockComments` when the file is missing a trailing blank line. ([@ericsullivan][]) | |||
| * [#6858](https://github.com/rubocop-hq/rubocop/issues/6858): Fix an incorrect auto-correct for `Lint/ToJSON` when there are no `to_json` arguments. ([@koic][]) | |||
| * [#6865](https://github.com/rubocop-hq/rubocop/pull/6865): Fix deactivated `StyleGuideBaseURL` for `Layout/ClassStructure`. ([@aeroastro][]) | |||
| * [#6869](https://github.com/rubocop-hq/rubocop/pull/6869): Fix false positive for `Rails/LinkToBlank`. ([@r7kamura][]) | |||
There was a problem hiding this comment.
Can you write a little more about the reason for false positive? It will be user friendly 😃
There was a problem hiding this comment.
Right. Slightly modified like this:
- Fix false positive for `Rails/LinkToBlank`.
+ Fix false positive for `Rails/LinkToBlank` when rel is a symbol value.
r7kamura
force-pushed
the
feature/rails-link-to-blank-symbol-rel
branch
from
77282a0
to
a8aebed
Compare
r7kamura
changed the title
Rails/LinkToBlank on symbol relRails/LinkToBlank when rel is a symbol value
r7kamura
force-pushed
the
feature/rails-link-to-blank-symbol-rel
branch
from
a8aebed
to
3138f0a
Compare
koic
approved these changes
Apr 1, 2019
Drenmi
reviewed
Apr 1, 2019
| @@ -22,7 +22,7 @@ class LinkToBlank < Cop | |||
| PATTERN | |||
|
|
|||
| def_node_matcher :includes_noopener?, <<-PATTERN | |||
| (pair {(sym :rel) (str "rel")} (str #contains_noopener?)) | |||
| (pair {(sym :rel) (str "rel")} {(str #contains_noopener?) (sym #contains_noopener?)}) | |||
There was a problem hiding this comment.
I could be wrong, but I think you could do:
({str sym} #contains_noopener?)
Don't take my word for it though. I haven't tested the pattern. 🙂
Drenmi
reviewed
Apr 1, 2019
| @@ -79,10 +79,10 @@ def add_rel(send_node, offence_node, corrector) | |||
| corrector.insert_after(range, new_rel_exp) | |||
| end | |||
|
|
|||
| def contains_noopener?(str) | |||
| return false unless str | |||
| def contains_noopener?(value) | |||
r7kamura
force-pushed
the
feature/rails-link-to-blank-symbol-rel
branch
from
3138f0a
to
2350e8c
Compare
r7kamura
force-pushed
the
feature/rails-link-to-blank-symbol-rel
branch
from
2350e8c
to
8f6b191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code should be valid on
Rails/LinkToBlankcop, but it's not on rubocop v0.66.0 because rel value is a Symbol.This PR is related to #6868.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.