Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default PreferredName to e for Naming/RescuedExceptionsVariableName #6881

Conversation

koic
Copy link
Member

@koic koic commented Apr 4, 2019

Follow up f0959e8.

The default PreferredName of Naming/RescuedExceptionsVariableName cop is e in the following discussion.
#6460 (comment)

This PR sets default PreferredName to e for Naming/RescuedExceptionsVariableName.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…bleName`

Follow up rubocop@f0959e8.

The default `PreferredName` of `Naming/RescuedExceptionsVariableName` cop
is `e` in the following discussion.

rubocop#6460 (comment)

This PR sets default `PreferredName` to `e` for `Naming/RescuedExceptionsVariableName`.
@koic
Copy link
Member Author

koic commented Apr 4, 2019

This is a large number of offenses expected, so I'd like to quickly release RuboCop 0.67.1.

@bbatsov bbatsov merged commit d0677d7 into rubocop:master Apr 4, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 4, 2019

Yeah, my bad.

@koic koic deleted the default_prefer_name_e_for_rescued_exceptions_variable_name branch April 4, 2019 17:10
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 4, 2019

Done.

@koic
Copy link
Member Author

koic commented Apr 4, 2019

Thanks for quick release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants