handle autocorrect exception in Style/BlockComments #6856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsullivan
force-pushed
the
handle_exception_in_block_comments
branch
2 times, most recently
from
f26c39d
to
0d0b279
Compare
koic
reviewed
Mar 22, 2019
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Bug fixes | |||
| * [#6855](https://github.com/rubocop-hq/rubocop/pull/6855): Fix an exception in `Rails/RedundantReceiverInWithOptions` when the body is empty. ([@ericsullivan][]) | |||
| * [#6856](https://github.com/rubocop-hq/rubocop/pull/6856): Fix AutoCorrect exception in `Style::BlockComments` when the file is missing a trailing blank line. ([@ericsullivan][]) | |||
There was a problem hiding this comment.
It is a small point. It would be better to write Style::BlockComments as Style/BlockComments.
There was a problem hiding this comment.
ah, good point. The wording was a little different from previous auto-correction fixes, so I adjusted that as well.
When a file ends with `=end` and does not have a final newline, the autocorrect code of Style/BlockComments was producing an exception. This change handles the exception and adds a final newline.
ericsullivan
force-pushed
the
handle_exception_in_block_comments
branch
from
0d0b279
to
1537862
Compare
koic
approved these changes
Mar 22, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file ends with
=endand does not have a final newline, theautocorrect code of Style/BlockComments was producing an exception.
This change handles the exception and adds a final newline.
Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.