Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails/LinkToBlank auto-correct bug when using symbol for target #6868

Merged

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Apr 1, 2019

I fixed a bug on Rails/LinkToBlank auto-correction logic when using a symbol literal for the target value.

Source

link_to 'Click here', 'https://www.example.com', target: :_blank

Expected

link_to 'Click here', 'https://www.example.com', target: :_blank, rel: :noopener

Actual

link_to 'Click here', 'https://www.example.com', target: :_blank, rel: :noopener:

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov bbatsov merged commit 81dcb45 into rubocop:master Apr 1, 2019
@r7kamura r7kamura deleted the feature/rails-link-to-blank-symbol branch April 1, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants