Added support for PHP 8 (fixes #69) #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixJacobi
commented
May 23, 2021
FelixJacobi
commented
May 23, 2021
FelixJacobi
added a commit
to FelixJacobi/bigbluebutton-api-php
that referenced
this pull request
May 23, 2021
I noted that the UrlBuilder always prepends & to the checksum parameter even if the parameters. The final URL then looks like [...]/getMeetings?&chkecksum=[...]. This breaks nothing but is a bit confusing. Therefor: Fixed and test case added. As I am currently working with PHP 8, this is based on the PHP 8 PR (littleredbutton#70) and a for now a draft for this reason.
FelixJacobi
added a commit
to FelixJacobi/bigbluebutton-api-php
that referenced
this pull request
May 24, 2021
I noted that the UrlBuilder always prepends & to the checksum parameter even if the parameters. The final URL then looks like [...]/getMeetings?&chkecksum=[...]. This breaks nothing but is a bit confusing. Therefor: Fixed and test case added. As I am currently working with PHP 8, this is based on the PHP 8 PR (littleredbutton#70) and a for now a draft for this reason.
SamuelWei
added a commit
that referenced
this pull request
May 24, 2021
I noted that the UrlBuilder always prepends & to the checksum parameter even if the parameters. The final URL then looks like [...]/getMeetings?&chkecksum=[...]. This breaks nothing but is a bit confusing. Therefor: Fixed and test case added. As I am currently working with PHP 8, this is based on the PHP 8 PR (#70) and a for now a draft for this reason. Co-authored-by: Samuel Weirich <samuel.weirich@gmx.de>
FelixJacobi
force-pushed
the
php8
branch
2 times, most recently
from
c552f2c
to
92e2794
Compare
|
Should be ready for review now. |
SamuelWei
reviewed
May 27, 2021
SamuelWei
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #69.
fix #69
fix #71