forked from bigbluebutton/bigbluebutton-api-php
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PHP 8 #69
Comments
Note: It has been updated to work on PHP 8 so far, but a future PHP 9 will not be supported anymore, so it would consider to refactor it out of the tests in a later PR. |
Great idea 👍 |
See #70. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
composer.json
and some (dev) dependencies currently does not allow to run this library on PHP 8. I guess that the code here should be almost fine and only thecomposer.json
and incompatible dependencies needs to be updated.Therefore, I would switch the semver constraint to allow all future PHP major versions (e.g.
>=7.2
) as I guess that there will be only a few minor compatibility issues on every new PHP major version, if there should be any at all.Finally, PHP 8 (and 8.1 directly?) should be added to the CI.
I would take a look on this in the next days.
The text was updated successfully, but these errors were encountered: