Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 8 #69

Closed
FelixJacobi opened this issue May 18, 2021 · 3 comments · Fixed by #70
Closed

Support for PHP 8 #69

FelixJacobi opened this issue May 18, 2021 · 3 comments · Fixed by #70

Comments

@FelixJacobi
Copy link
Member

FelixJacobi commented May 18, 2021

The composer.json and some (dev) dependencies currently does not allow to run this library on PHP 8. I guess that the code here should be almost fine and only the composer.json and incompatible dependencies needs to be updated.

  Problem 1
    - Root composer.json requires php ^7.2 but your php version (8.0.5) does not satisfy that requirement.
  Problem 2
    - fzaninotto/faker is locked to version v1.9.2 and an update of this package was not requested.
    - fzaninotto/faker v1.9.2 requires php ^5.3.3 || ^7.0 -> your php version (8.0.5) does not satisfy that requirement.
  Problem 3
    - php-coveralls/php-coveralls is locked to version v2.2.0 and an update of this package was not requested.
    - php-coveralls/php-coveralls v2.2.0 requires php ^5.5 || ^7.0 -> your php version (8.0.5) does not satisfy that requirement.

Therefore, I would switch the semver constraint to allow all future PHP major versions (e.g. >=7.2) as I guess that there will be only a few minor compatibility issues on every new PHP major version, if there should be any at all.

Finally, PHP 8 (and 8.1 directly?) should be added to the CI.

I would take a look on this in the next days.

@FelixJacobi
Copy link
Member Author

Note: faker is considered as dead: https://marmelab.com/blog/2020/10/21/sunsetting-faker.html

It has been updated to work on PHP 8 so far, but a future PHP 9 will not be supported anymore, so it would consider to refactor it out of the tests in a later PR.

@sualko
Copy link
Member

sualko commented May 18, 2021

Great idea 👍

@FelixJacobi
Copy link
Member Author

See #70.

@althaus althaus mentioned this issue Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants