Skip to content

Commit

Permalink
Added support for PHP 8
Browse files Browse the repository at this point in the history
  • Loading branch information
FelixJacobi committed Jun 2, 2021
1 parent 45766d7 commit 52f59ce
Show file tree
Hide file tree
Showing 4 changed files with 91 additions and 71 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php-versions: ['7.2','7.3','7.4']
php-versions: ['7.2','7.3','7.4','8.0']
experimental: [false]
include:
- php-versions: '8.1'
Expand Down
8 changes: 4 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"docs": "https://github.com/littleredbutton/bigbluebutton-api-php/blob/master/README.md"
},
"require": {
"php": "^7.2",
"php": ">=7.2",
"ext-curl": "*",
"ext-simplexml": "*",
"ext-mbstring": "*",
Expand All @@ -74,10 +74,9 @@
"require-dev": {
"composer/composer": "^1.10.0",
"phpunit/phpunit": "^8",
"fzaninotto/faker": "~1.9.0",
"friendsofphp/php-cs-fixer": "2.*",
"squizlabs/php_codesniffer": "3.*",
"php-coveralls/php-coveralls": "~2.2.0",
"php-coveralls/php-coveralls": "^2.4.0",
"brainmaestro/composer-git-hooks": "^2.8",
"vimeo/psalm": "^4.5",
"psr/http-client": "^1.0",
Expand All @@ -87,7 +86,8 @@
"symfony/http-client-contracts": "^1.1|^2.0",
"symfony/http-client": "^4.4|^5.0",
"symfony/process": "^3.4|^4.0|^5.0",
"nyholm/psr7": "^1.4"
"nyholm/psr7": "^1.4",
"fakerphp/faker": "^1.14"
},
"autoload": {
"psr-4": {
Expand Down
146 changes: 80 additions & 66 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions tests/unit/Http/SetCookieTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,12 @@ public function cookieParserDataProvider(): array
*/
public function testParseCookie($cookie, array $parsed): void
{
if (\PHP_VERSION_ID >= 80000) {
self::markTestSkipped('This test is possibly using incorrect code and is broken starting from PHP 8. ' .
'See https://github.com/littleredbutton/bigbluebutton-api-php/pull/70#discussion_r637602067 and ' .
'https://github.com/guzzle/guzzle/issues/2894 for details.');
}

foreach ((array) $cookie as $v) {
$c = SetCookie::fromString($v);
$p = $c->toArray();
Expand Down

0 comments on commit 52f59ce

Please sign in to comment.