Skip to content

Commit

Permalink
Added support for PHP 8
Browse files Browse the repository at this point in the history
  • Loading branch information
FelixJacobi committed May 24, 2021
1 parent 86bf84a commit c552f2c
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php-versions: ['7.2','7.3','7.4']
php-versions: ['7.2','7.3','7.4','8.0']
experimental: [false]
include:
- php-versions: '8.1'
Expand Down
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"docs": "https://github.com/littleredbutton/bigbluebutton-api-php/blob/master/README.md"
},
"require": {
"php": "^7.2",
"php": ">=7.2",
"ext-curl": "*",
"ext-simplexml": "*",
"ext-mbstring": "*",
Expand All @@ -74,10 +74,10 @@
"require-dev": {
"composer/composer": "^1.10.0",
"phpunit/phpunit": "^8",
"fzaninotto/faker": "~1.9.0",
"fzaninotto/faker": "dev-master",
"friendsofphp/php-cs-fixer": "2.*",
"squizlabs/php_codesniffer": "3.*",
"php-coveralls/php-coveralls": "~2.2.0",
"php-coveralls/php-coveralls": "^2.4.0",
"brainmaestro/composer-git-hooks": "^2.8",
"vimeo/psalm": "^4.5",
"psr/http-client": "^1.0",
Expand Down
51 changes: 29 additions & 22 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/unit/Http/SetCookieTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ public function testParseCookie($cookie, array $parsed): void

if (isset($p['Expires'])) {
// Remove expires values from the assertion if they are relatively equal
if (\abs($p['Expires'] != \strtotime((string) $parsed['Expires'])) < 40) {
if (\abs((int) ($p['Expires'] != \strtotime((string) $parsed['Expires']))) < 40) {
unset($p['Expires']);
unset($parsed['Expires']);
}
Expand Down

0 comments on commit c552f2c

Please sign in to comment.