Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove faker from tests #71

Closed
FelixJacobi opened this issue May 23, 2021 · 3 comments · Fixed by #70
Closed

Remove faker from tests #71

FelixJacobi opened this issue May 23, 2021 · 3 comments · Fixed by #70

Comments

@FelixJacobi
Copy link
Member

faker is considered as dead: https://marmelab.com/blog/2020/10/21/sunsetting-faker.html

It has been updated to work on PHP 8 so far, but a future PHP 9 will not be supported anymore, so it would consider to refactor it out of the tests.

To run it with PHP 8 a kind of evil hack was required: #70 (comment)

@SamuelWei
Copy link

To be honest François Zaninotto has a point, we don't need a 3MB library to create some meeting room names, welcome texts, dialing numbers and usernames.

However, it might be a solution for now to switch to the faker fork used by laravel https://github.com/FakerPHP/Faker

@FelixJacobi
Copy link
Member Author

FelixJacobi commented May 24, 2021

To be honest François Zaninotto has a point, we don't need a 3MB library to create some meeting room names, welcome texts, dialing numbers and usernames.

However, it might be a solution for now to switch to the faker fork used by laravel https://github.com/FakerPHP/Faker

Good point, I will play around with it and include it in the PHP 8 PR if its suitable. In this case we can revoke the master hack there.

@FelixJacobi
Copy link
Member Author

FelixJacobi commented May 24, 2021

But in long term I would prefer to use more static data in tests as using random data each time mades the test kind of unpredictable. Sure it can make sense to test with random data, but I am not sure this belongs to unit and integration tests, which are mainly intended to show me that I did not break any existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants