-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove faker from tests #71
Comments
To be honest François Zaninotto has a point, we don't need a 3MB library to create some meeting room names, welcome texts, dialing numbers and usernames. However, it might be a solution for now to switch to the faker fork used by laravel https://github.com/FakerPHP/Faker |
Good point, I will play around with it and include it in the PHP 8 PR if its suitable. In this case we can revoke the master hack there. |
But in long term I would prefer to use more static data in tests as using random data each time mades the test kind of unpredictable. Sure it can make sense to test with random data, but I am not sure this belongs to unit and integration tests, which are mainly intended to show me that I did not break any existing code. |
faker
is considered as dead: https://marmelab.com/blog/2020/10/21/sunsetting-faker.htmlIt has been updated to work on PHP 8 so far, but a future PHP 9 will not be supported anymore, so it would consider to refactor it out of the tests.
To run it with PHP 8 a kind of evil hack was required: #70 (comment)
The text was updated successfully, but these errors were encountered: